Format Python code with black and isort #201
Conversation
| """ | ||
| From https://www.learnpythonwithrune.org/numpy-compute-mandelbrot-set-by-vectorization/. |
There was a problem hiding this comment.
Removing the "From" prefix doesn't seem necessary.
There was a problem hiding this comment.
There was a problem hiding this comment.
We could put From on a separate line.
pyscriptjs/src/pyscript.py
Outdated
| @@ -68,7 +72,7 @@ def format_mime(obj): | |||
| format_dict, md_dict = mimebundle | |||
| else: | |||
| format_dict = mimebundle | |||
| md_dict = {} | |||
| md_dict = {} # noqa: F841 | |||
There was a problem hiding this comment.
md_dict can be removed if it's not used. We shouldn't add the noqa here.
|
@cclauss How would you feel about moving the linting config to pre-commit, so we make it easier to use locally, cross-platform and allow us to expand it to cover other types of code quality checks? /cc @mattkram |
|
@cclauss Thank you for the PR and for prompting this discussion. As @pww217 mentioned, we're working to integrate these types of formatting checks and linting into Thank you for introducing me to Tomorrow is FOSS Friday at Anaconda, and I will return to this PR after integrating some additional |
Adds spellchecking and Python linting to the GitHub Action
black --skip-string-normalization .isort --profile black .codespell --count --skip="*.js,*.json"flake8 --builtins=Element,PyItemTemplate,PyListTemplate --max-complexity=10 --max-line-length=88