8000 Pydom add better support for select element by fpliger · Pull Request #1887 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

Pydom add better support for select element #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 6, 2023
Merged

Pydom add better support for select element #1887

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e16824c
add tests for select options
fpliger Dec 5, 2023
4e62787
add classes to support select and options management
fpliger Dec 5, 2023
2add3dd
fix add methond and implement clear on options
fpliger Dec 5, 2023
c201b1d
fix optionsproxy.add
fpliger Dec 5, 2023
134b9cb
fix select.add method
fpliger Dec 6, 2023
a882c06
add test adding a second option to select
fpliger Dec 6, 2023
fb9a70a
add tests around adding options in multiple flavors
fpliger Dec 6, 2023
d7cd23a
add test to add an option by passing the option it wants to be added …
fpliger Dec 6, 2023
2453e72
complete test around adding options
fpliger Dec 6, 2023
1da8859
add select to add test on remove
fpliger Dec 6, 2023
70c65a3
add tests and support for selected item
fpliger Dec 6, 2023
14f9c5d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 6, 2023
c9fa636
Merge branch 'main' into fpliger/pydom_select_support
WebReflection Dec 6, 2023
a9bce47
Merge branch 'main' into fpliger/pydom_select_support
WebReflection Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test to add an option by passing the option it wants to be added … 
…before
  • Loading branch information
@fpliger
fpliger committed Dec 6, 2023
commit d7cd23a9056a3092f8af71aab068345ed819b438
15 changes: 14 additions & 1 deletion pyscript.core/test/pyscript_dom/tests/test_dom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,5 +373,18 @@ def test_select_element_add(self):
assert select.options[1].value == "2"
assert select.options[1].html == "Option 2"
select.options.add(value = "2", html = "Option 2", before = 1)


# EXPECT the select element to have 3 options
assert len(select.options) == 3

# EXPECT the middle option to have the value and html we passed in
assert select.options[0].value == "1"
assert select.options[0].html == "Option 1"
assert select.options[1].value == "2"
assert select.options[1].html == "Option 2"
assert select.options[2].value == "3"
assert select.options[2].html == "Option 3"
assert select.options[3].value == ""
assert select.options[3].html == ""

select.options.clear()
0