8000 Pydom add better support for select element by fpliger · Pull Request #1887 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

Pydom add better support for select element #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Dec 6, 2023
Merged

Pydom add better support for select element #1887

merged 14 commits into from
Dec 6, 2023

Conversation

fpliger
Copy link
Contributor
@fpliger fpliger commented Dec 6, 2023

Description

This PR adds better support for select elements (and related options)

Checklist

NOTE: need to add docs...

  • All tests pass locally
  • I have updated CHANGELOG.md
  • I have created documentation for this(if applicable)

WebReflection
WebReflection approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor
@WebReflection WebReflection left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpliger fpliger merged commit c0d45d3 into main Dec 6, 2023
@fpliger fpliger deleted the fpliger/pydom_select_support branch December 6, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WebReflection WebReflection WebReflection approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpliger @WebReflection
0