10000 Unskip some tests, delete others by antocuni · Pull Request #1742 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

Unskip some tests, delete others #1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Sep 25, 2023
Merged

Unskip some tests, delete others #1742

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a555b16
disable worker tests for now, as they are NOT testing things on worke…
antocuni Sep 20, 2023
f0789a8
one test passes. Improve the others, but they still fail
antocuni Sep 20, 2023
7554792
create a fake favicon.ico, so that we finally stop seeing all 404s in…
antocuni Sep 20, 2023
019fae8
unskip&fix these test
antocuni Sep 21, 2023
c326eef
unskip a test, explain the other
antocuni Sep 21, 2023
735f268
pyscript.Element is gone, remove its tests
antocuni Sep 21, 2023
0d41146
unskip these test, they now work
antocuni Sep 21, 2023
64a571c
kill tests related to Element
antocuni Sep 21, 2023
8184006
unskip this test
antocuni Sep 21, 2023
335d59b
fix the test and improve the skip message
antocuni Sep 21, 2023
374ee03
it is no longer possible to change the pyodide version. Kill this test
antocuni Sep 21, 2023
f5b7903
more tweaks
antocuni Sep 21, 2023
d0cc07c
Merge branch 'main' into antocuni/unskip-more-tests
antocuni Sep 25, 2023
ec42943
Merge remote-tracking branch 'origin/main' into antocuni/unskip-more-…
antocuni Sep 25, 2023
d67ca1d
kill leftover from merge
antocuni Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
kill leftover from merge
  • Loading branch information
@antocuni
antocuni committed Sep 25, 2023
commit d67ca1d9c7ac51840c95c651d046a537ed7d3b09
51 changes: 0 additions & 51 deletions pyscript.core/tests/integration/test_py_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,57 +134,6 @@ def test_multiple_py_config(self):
)
assert banner.text_content() == expected

<<<<<<< HEAD
=======
@pytest.mark.skip("Interpreters key is not implemented in PyScript Next")
def test_no_interpreter(self):
snippet = """
<py-config type="json">
{
"interpreters": []
}
</py-config>
"""
self.pyscript_run(snippet, wait_for_pyscript=False)
div = self.page.wait_for_selector(".py-error")
assert (
div.text_content() == "(PY1000): Fatal error: config.interpreter is empty"
)

@pytest.mark.skip("Interpreters key is not implemented in PyScript Next")
def test_multiple_interpreter(self):
snippet = """
<py-config type="json">
{
"interpreters": [
{
"src": "https://cdn.jsdelivr.net/pyodide/v0.23.2/full/pyodide.js",
"name": "pyodide-0.23.2",
"lang": "python"
},
{
"src": "http://...",
"name": "this will be ignored",
"lang": "this as well"
}
]
}
</py-config>

<script type="py">
import js
js.console.log("hello world");
</script>
"""
self.pyscript_run(snippet)
banner = self.page.wait_for_selector(".py-warning")
expected = (
"Multiple interpreters are not supported yet.Only the first will be used"
)
assert banner.text_content() == expected
assert self.console.log.lines[-1] == "hello world"

>>>>>>> origin/main
def test_paths(self):
self.writefile("a.py", "x = 'hello from A'")
self.writefile("b.py", "x = 'hello from B'")
Expand Down
0