Unskip some tests, delete others #1742
Conversation
… test. This fixes this test as well (I have no idea how it could possibly work in pyscript classic)
|
I love this PR and I badly want this in but we had this discussion with Fabio before and there was no super clear outcome ... the |
I assumed that pyweb had its own tests, but I admit I didn't check. |
| @@ -81,12 +81,12 @@ def test_script_type_py_src_attribute(self): | |||
| ) | |||
| assert self.console.log.lines[-1] == "hello from foo" | |||
|
|
|||
| @pytest.mark.skip("FIXME: test failure is unrelated") | |||
| @pytest.mark.skip("FIXME: wait_for_pyscript is broken") | |||
There was a problem hiding this comment.
I assume wait_for_pyscript is broken for the same execution-order reasons? Or is it more generally broken? Again, really just curious for later.
There was a problem hiding this comment.
I assume wait_for_pyscript is broken for the same execution-order reasons? Or is it more generally broken?
yes, it's the same problem.
The problem is that the current version of wait_for_pyscript() waits for PyScript Ready which is printed before the tags are executed, not after.
Basically right now all the tests are at risk of being flaky, but most of them are just fast enough that they work in practice.
This is another PR which aims to clean up a bit the testsuite and integration tests.
Highlights:
@skippedtests just worked -- I unskipped themMoreover, I killed/removed the ones which no longer make sense in the context of pyscript next; in particular, I removed all the ones which tested
Element(which is now gone) and the one which testedpy-configfeatures which are no longer needed (e.g., multiple interpreters).The testsuite passes locally.
I plan to open an umbrella issue where to keep track of the remaining skipped/xfailed tests, so be handled after the release of RC1