8000 WIP: refactor annotation injection for known (often generic) types by sydney-runkle · Pull Request #9979 · pydantic/pydantic · GitHub
[go: up one dir, main page]
Skip to content

WIP: refactor annotation injection for known (often generic) types #9979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sydney-runkle merged 10 commits into from
Jul 29, 2024
Merged

WIP: refactor annotation injection for known (often generic) types #9979

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2b2a0da
add new make directive for test w o docs
sydney-runkle Jul 25, 2024
0796a45
remove unused config arg
sydney-runkle Jul 25, 2024
6a0c94f
consistency with sequence
sydney-runkle Jul 25, 2024
46508a4
remove unused args
sydney-runkle Jul 25, 2024
e086b5e
annotation tests now failing, but at least addressing specific cases
sydney-runkle Jul 25, 2024
6604ec1
change order of get_origin and annotations app
sydney-runkle Jul 25, 2024
f31e066
add xfails
sydney-runkle Jul 29, 2024
8cdcd24
temp patch for fastapi tests
sydney-runkle Jul 29, 2024
e3c7108
try another alternate workaround
sydney-runkle Jul 29, 2024
8000
228ed5b
another attempt
sydney-runkle Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
try another alternate workaround
  • Loading branch information
@sydney-runkle
sydney-runkle committed Jul 29, 2024
commit e3c710854aecce7ab394c4d241bfb9754e4e63a6
4 changes: 2 additions & 2 deletions tests/test_fastapi.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ set -e
cd fastapi
git fetch --tags

# waiting on a fix for a bug introduced in v72.0.0, see https://github.com/pypa/setuptools/issues/4520
# waiting on a fix for a bug introduced in v72.0.0, see https://github.com/pypa/setuptools/issues/4519
# problem lies in sqlalchemy
python -m pip install 'setuptools<72.0.0'

pip install -r requirements.txt
pip install --no-build-isolation -r requirements.txt
# Install the version of pydantic from the current branch, not the released version used by fastapi
pip uninstall -y pydantic
cd .. && pip install . && cd fastapi
Expand Down
0