WIP: refactor annotation injection for known (often generic) types #9979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more
8000
about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
228ed5b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://67546565.pydantic-docs.pages.dev |
| Branch Preview URL: | https://change-match-order.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #9979 will not alter performanceComparing Summary
|
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
Contributor
Author
|
If approved, I can mark these as xfails and attach a github issue to be addressed pre v2.9 :) |
Member
|
Looks good to me but tests are failing. Please fix those before we can merge. |
adriangb
approved these changes
Jul 29, 2024
This was referenced Aug 1, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main accomplishments of this PR, which are easiest to review on a commit by commit basis.
get_origincheck before the annotations prep to ensure we use a more simple path for types likelist[str]Seeing some performance improvements on the
_apply_annotationsfront :). Looks like a 2.8x speedup in the annotation prep function for known types.I'm looking for feedback on the above, as well as the fact that there are now 5 failing tests related to the fact that we now fail to raise annotation application errors, similar to #9977 (comment).
I would like to address this in a separate PR as mentioned in my comment above. If you agree @adrian, I can mark these tests as xfail as well.