8000 Fix `validate_call` schema generation and doc error for `TypedDict` by adriangb · Pull Request #6370 · pydantic/pydantic · GitHub
[go: up one dir, main page]
Skip to content

Fix validate_call schema generation and doc error for TypedDict #6370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 2, 2023
Merged

Fix validate_call schema generation and doc error for TypedDict #6370

merged 4 commits into from
Jul 2, 2023

Conversation

adriangb
Copy link
Member
@adriangb adriangb commented Jul 2, 2023 •
edited by pydantic-hooky bot
Loading

Fixes #6356

Selected Reviewer: @lig

@cloudflare-workers-and-pages
Copy link
cloudflare-workers-and-pages bot commented Jul 2, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 893e2db
Status: ✅  Deploy successful!
Preview URL: https://08763d2a.pydantic-docs2.pages.dev
Branch Preview URL: https://fix-doc-error-description.pydantic-docs2.pages.dev

View logs

@adriangb adriangb changed the title Fix TypedDict error description Fix TypedDict error description and validate_call schema generation Jul 2, 2023
@adriangb
Copy link
Member Author
adriangb commented Jul 2, 2023

please review

@adriangb adriangb mentioned this pull request Jul 2, 2023
Closed
Kludex
Kludex requested changes Jul 2, 2023
View reviewed changes
Copy link
Member
@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test with a TypedDict on the signature or a BaseModel based class or both?

@pydantic-hooky pydantic-hooky bot added awaiting author revision awaiting changes from the PR author and removed ready for review labels Jul 2, 2023
@pydantic-hooky pydantic-hooky bot assigned adriangb and unassigned lig Jul 2, 2023
@Kludex
Copy link
Member
Kludex commented Jul 2, 2023

About the confusion that I did on the version being 3.11: there's a comment on the standard library that I believe is not correct about this - this is a comment to remind me to check this when I get home.

@adriangb
Copy link
Member Author
adriangb commented Jul 2, 2023 •
edited
Loading

I'm sure we need typing.TypedDict to be 3.12+ because of python/cpython#103698

@adriangb adriangb changed the title Fix TypedDict error description and validate_call schema generation Fix validate_call schema generation and doc error for TypedDict Jul 2, 2023
@adriangb
Copy link
Member Author
adriangb commented Jul 2, 2023

@Kludex added a test and fixes some other bugs with validate_call

@adriangb
Copy link
Member Author
adriangb commented Jul 2, 2023

please review

8000
@pydantic-hooky pydantic-hooky bot added ready for review and removed awaiting author revision awaiting changes from the PR author labels Jul 2, 2023
@pydantic-hooky pydantic-hooky bot assigned lig and unassigned adriangb Jul 2, 2023
@adriangb adriangb requested a review from Kludex July 2, 2023 18:28
Kludex
Kludex approved these changes Jul 2, 2023
View reviewed changes
Copy link
Member
@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😁🙏

@adriangb adriangb merged commit 61cdaea into main Jul 2, 2023
@adriangb adriangb deleted the fix-doc-error-description branch July 2, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees

@lig lig

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypedDict can not be used with V2
3 participants
@adriangb @Kludex @lig
0