✏️ Invert order of typing <-> typing_extensions
#6359
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review |
Deploying with
|
| Latest commit: |
3e60c77
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8ae9ac45.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://fix-docs-error.pydantic-docs2.pages.dev |
hramezani
reviewed
Jul 2, 2023
docs/usage/errors.md
Outdated
| @@ -290,8 +290,7 @@ except PydanticUserError as exc_info: | |||
|
|
|||
| ## `TypedDict` version {#typed-dict-version} | |||
|
|
|||
| This error is raised when you use `typing_extensions.TypedDict` | |||
| instead of `typing.TypedDict` on Python < 3.11. | |||
| This error is raised when you use `typing.TypedDict` instead of `typing_extensions.TypedDict` on Python < 3.12. | |||
There was a problem hiding this comment.
Shouldn't it be Python < 3.11?
There is a note in docstring of the method that says we only support typing.TypedDict on Python >= 3.11.
But in the error message of the same function, we have 3.12
I think we need to change the docstring or error message
There was a problem hiding this comment.
Will you fix it in this commit?
There was a problem hiding this comment.
Ok, it looks like it's supposed to be < 3.11 instead of < 3.12.
There was a problem hiding this comment.
It needs to be 3.12 for TypedDic
|
please review |
|
Superseded by #6370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description of the error message is not accurate.
Selected Reviewer: @adriangb