8000 Adopt ghi_clear variable name for clearsky GHI by RDaxini · Pull Request #2306 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]

Skip to content

Adopt ghi_clear variable name for clearsky GHI #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Dec 16, 2024
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
*_test_not_working_*
  • Loading branch information
RDaxini committed Nov 25, 2024
commit b55f56e822cf92e35c9aabbae1f3b4131454da5f
6 changes: 6 additions & 0 deletions pvlib/tests/test_irradiance.py
Original file line number Diff line number Diff line change
Expand Up @@ -1235,6 +1235,12 @@ def test_clearsky_index():
assert_series_equal(out, expected)


def test_clearsky_index_renaming():
with pytest.warns(pvlibDeprecationWarning, match='ghi_clear'):
ghi, clearsky_ghi = 200, 300
irradiance.clearsky_index(ghi, clearsky_ghi)


def test_clearness_index():
ghi = np.array([-1, 0, 1, 1000])
solar_zenith = np.array([180, 90, 89.999, 0])
Expand Down
Loading
0