8000 Adopt ghi_clear variable name for clearsky GHI by RDaxini · Pull Request #2306 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

Adopt ghi_clear variable name for clearsky GHI #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Dec 16, 2024
Merged

Adopt ghi_clear variable name for clearsky GHI #2306

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
ee88e86
non-breaking: clearsky_ghi -> ghi_clear
RDaxini Nov 25, 2024
ed0d2de
breaking: clearsky_ghi & ghi_clearsky -> ghi_clear
RDaxini Nov 25, 2024
b55f56e
*_test_not_working_*
RDaxini Nov 25, 2024
8a90595
Apply suggestions from code review
RDaxini Nov 25, 2024
ef4b635
change all variables
RDaxini Nov 25, 2024
49c5268
Update pvlib/tests/test_irradiance.py
RDaxini Nov 26, 2024
75c2c38
dirindex deprecation test
RDaxini Nov 26, 2024
b1d6793
Update pvlib/tests/test_irradiance.py
RDaxini Nov 26, 2024
0af7ffa
add @fail_on_pvlib_version("0.12") decorator
RDaxini Nov 26, 2024
002b671
Update test_irradiance.py
RDaxini Nov 26, 2024
a68dda3
correct version number
RDaxini Nov 27, 2024
5978a0f
Merge remote-tracking branch 'upstream/main' into ghi_clear_naming
RDaxini Dec 13, 2024
aff87e9
Update irradiance.py
RDaxini Dec 13, 2024
9215eab
0.12->0.13 in test_irradiance.py
RDaxini Dec 13, 2024
742dd34
Update v0.11.2.rst
RDaxini Dec 13, 2024
437c2d3
Update pvlib/tests/test_irradiance.py
RDaxini Dec 14, 2024
26e3618
indents
RDaxini Dec 16, 2024
113ab9b
add missing .. versionchanged::
RDaxini Dec 16, 2024
447f031
refine test
RDaxini Dec 16, 2024
93d5302
Merge remote-tracking branch 'upstream/main' into ghi_clear_naming
RDaxini Dec 16, 2024
15bffc5
Update pvlib/irradiance.py
RDaxini Dec 16, 2024
e2e4fbc
Update irradiance.py
RDaxini Dec 16, 2024
91a5805
Merge branch 'ghi_clear_naming' of https://github.com/RDaxini/pvlib-p…
RDaxini Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
0.12->0.13 in test_irradiance.py
  • Loading branch information
@RDaxini
RDaxini committed Dec 13, 2024
commit 9215eab5faa165db1934ba2b1d083c39e279d1e5
4 changes: 2 additions & 2 deletions pvlib/tests/test_irradiance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,7 +1095,7 @@ def test_dirindex(times):
equal_nan=True)


@fail_on_pvlib_version("0.12")
@fail_on_pvlib_version("0.13")
def test_dirindex_ghi_clearsky_deprecation():
with pytest.warns(pvlibDeprecationWarning, match='ghi_clear'):
times = pd.DatetimeIndex(['2014-06-24T18-1200'])
Expand Down Expand Up @@ -1283,7 +1283,7 @@ def test_clearsky_index():
assert_series_equal(out, expected)


@fail_on_pvlib_version("0.12")
@fail_on_pvlib_version("0.13")
def test_clearsky_index_clearsky_ghi_deprecation():
with pytest.warns(pvlibDeprecationWarning, match='ghi_clear'):
ghi, clearsky_ghi = 200, 300
Expand Down
Loading
0