8000 Handle poa_global and effective_irradiance for cell temperature models by cwhanse · Pull Request #1129 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

Handle poa_global and effective_irradiance for cell temperature models #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 14, 2021
Merged

Handle poa_global and effective_irradiance for cell temperature models #1129

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9317efb
add switch between poa_global and effective_irradiance for cell
cwhanse Jan 11, 2021
68b7cf7
handle tuple and single DF
cwhanse Jan 12, 2021
8166cf6
handle tuples etc., improve some docstrings
cwhanse Jan 12, 2021
7e54534
more handle tuples
cwhanse Jan 12, 2021
40d8734
add missing argument
cwhanse Jan 12, 2021
c720a75
whatsnew
cwhanse Jan 13, 2021
2211fed
edits from review, add test for different poa_global and effective_ir…
cwhanse Jan 13, 2021
9174fe3
move to helper function, add test
cwhanse Jan 13, 2021
8c3e643
edits
cwhanse Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
edits
  • Loading branch information
@cwhanse
cwhanse committed Jan 14, 2021
commit 8c3e643720e187596da7cd280824400706e2f6bb
5 changes: 3 additions & 2 deletions pvlib/modelchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1751,9 +1751,10 @@ def run_model_from_effective_irradiance(self, data=None):

Notes
-----
Optional `data` columns ``'cell_temperature'``,
Optional ``data`` columns ``'cell_temperature'``,
``'module_temperature'`` and ``'poa_global'`` are used for determining
cell temperature.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not rendering as desired. might need a blank line here

https://pvlib-python--1129.org.readthedocs.build/en/1129/generated/pvlib.modelchain.ModelChain.run_model_from_effective_irradiance.html


* If optional column ``'cell_temperature'`` is present, these values
are used and `temperature_model` is ignored.
* If optional column ``'module_temperature'`` is preset,
Expand Down Expand Up @@ -1791,7 +1792,7 @@ def _irrad_for_celltemp(total_irrad, effective_irradiance):

Returns
-------
Series of tuple of Series
Series or tuple of Series
tuple if total_irrad is a tuple of DataFrame

"""
Expand Down
0