8000 Handle poa_global and effective_irradiance for cell temperature models by cwhanse · Pull Request #1129 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

Handle poa_global and effective_irradiance for cell temperature models #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 14, 2021
Merged

Handle poa_global and effective_irradiance for cell temperature models #1129

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9317efb
add switch between poa_global and effective_irradiance for cell
cwhanse Jan 11, 2021
68b7cf7
handle tuple and single DF
cwhanse Jan 12, 2021
8166cf6
handle tuples etc., improve some docstrings
cwhanse Jan 12, 2021
7e54534
more handle tuples
cwhanse Jan 12, 2021
40d8734
add missing argument
cwhanse Jan 12, 2021
c720a75
whatsnew
cwhanse Jan 13, 2021
2211fed
edits from review, add test for different poa_global and effective_ir…
cwhanse Jan 13, 2021
9174fe3
move to helper function, add test
cwhanse Jan 13, 2021
8c3e643
edits
cwhanse Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add missing argument
  • Loading branch information
@cwhanse
cwhanse committed Jan 12, 2021
commit 40d87346726e7b6624dfe818bfd781baa7452a3a
2 changes: 1 addition & 1 deletion pvlib/modelchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1560,7 +1560,7 @@ def _prepare_temperature(self, data=None):
# broadcast data to all arrays
data = (data,) * self.system.num_arrays
elif not isinstance(data, tuple):
return self._prepare_temperature_single_array(data)
return self._prepare_temperature_single_array(data, poa)
given_cell_temperature = tuple(itertools.starmap(
self._get_cell_temperature,
zip(data, poa, self.system.temperature_model_parameters)
Expand Down
0