Return default savefig transparency to False #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally I enforced the default behavior
rc['savefig.transparent'] = Trueto make saved figure backgrounds transparent by default. This can be nice when putting plots on slides, posters, or websites with different light-colored backgrounds.However, with the rising popularity of "dark modes" (on Github, macOS, twitter, etc.), this behavior more often results in users trying to read black text on dark backgrounds, and can be extremely frustrating and confusing. It also results in saved PDFs (which always show against white backgrounds) looking different from saved PNGs.
This PR reverts proplot to the more sensible default behavior of
rc['savefig.transparent'] = False.