8000 Return default savefig transparency to False by lukelbd · Pull Request #252 · proplot-dev/proplot · GitHub
[go: up one dir, main page]

Skip to content

Return default savefig transparency to False #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 29, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ ProPlot v0.7.0 (2021-06-30)

.. rubric:: Deprecated

* Change default :rcraw:`savefig.transparent` back to ``False`` (:pr:`252`). Dubious
justification for ``True`` in the first place, and makes default PNG proplot figures
unreadable wherever "dark mode" is enabled.
* Rename `SciVisColor` colormaps from ``Blue1``, ``Blue2``, etc. to plurals ``Blues1``,
``Blues2``, etc. to avoid name conflict with open-color colors. This permits making
monochromatic open-color maps with e.g. 10000 ``plot.Colormap('blue9')``, and feels more
Expand Down
7 changes: 2 additions & 5 deletions docs/basics.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,8 @@
# `matplotlib backend <https://matplotlib.org/faq/usage_faq#what-is-a-backend>`__
# -- the default background color is white when the figure is saved. This is done
# by setting :rcraw:`figure.facecolor` to gray, in order to improve contrast
# when working with figures.
# ProPlot also makes the default saved figure background *transparent*
# by setting :rcraw:`savefig.transparent` to ``True``
# and changes the default :rcraw:`savefig.format` from PNG to PDF
# for the following reasons:
# when working with figures, similar to MATLAB. ProPlot also changes the default
# :rcraw:`savefig.format` from PNG to PDF for the following reasons:
#
# #. Vector graphic formats are infinitely scalable.
# #. Vector graphic formats are preferred by academic journals.
Expand Down
2 changes: 1 addition & 1 deletion docs/projections.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@
#
# * ProPlot ensures that polar cartopy projections like
# `~cartopy.crs.NorthPolarStereo` have circular boundaries (see `this example\
# <https://scitools.org.uk/cartopy/docs/latest/gallery/always_circular_stereo>`__
# <https://scitools.org.uk/cartopy/docs/latest/gallery/lines_and_polygons/always_circular_stereo.html>`__
# from the cartopy website).
# * By default, non-polar cartopy projections are forced to have global extent
# with `~cartopy.mpl.geoaxes.GeoAxes.set_global` and polar cartopy projections
Expand Down
2 changes: 1 addition & 1 deletion proplot/figure.py
Original file line number Diff line number Diff line change
Expand Up @@ -1262,7 +1262,7 @@ def save(self, filename, **kwargs):
return self.savefig(filename, **kwargs)

def savefig(self, filename, **kwargs):
# Automatically expand user the user name. Undocumented because we
# Automatically expand the user name. Undocumented because we
# do not want to overwrite the matplotlib docstring.
# TODO: Concatenate docstrings.
if isinstance(filename, str):
Expand Down
2 changes: 1 addition & 1 deletion proplot/internals/rcsetup.py
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@
'savefig.dpi': 1200, # academic journal recommendations for raster line art
'savefig.facecolor': 'white', # different from figure.facecolor
'savefig.format': 'pdf', # most users use bitmap, but vector graphics are better
'savefig.transparent': True,
'savefig.transparent': False,
'xtick.direction': TICKDIR,
'xtick.labelsize': LABELSIZE,
'xtick.major.pad': TICKPAD,
Expand Down
0