E5ED [MDX] All test pass by seiyab · Pull Request #18936 · prettier/prettier · GitHub
[go: up one dir, main page]
Skip to content

[MDX] All test pass #18936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seiyab wants to merge 3 commits into
base: mdx
Choose a base branch
from
+82 −28
Open

[MDX] All test pass #18936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f734265
update visitor-keys snapshot
seiyab Mar 9, 2026
5748163
update fixture for embedded_language_formatting
seiyab Mar 11, 2026
a152716
add fixture of JS expression in for embeddedLanguageFormatting = 'off'
seiyab Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 46 additions & 18 deletions tests/format/misc/embedded_language_formatting/mdx/__snapshots__/format.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,16 @@ parsers: ["mdx"]
printWidth: 80
| printWidth
=====================================input======================================
<Heading hi='there'>Hello, world!
<Heading hi='there'>
Hello, world!
Comment on lines -87 to +88
Copy link
Collaborator Author
@seiyab seiyab Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New parser can't parse the previous input.

</Heading>
---
<Hello>
test <World /> test
</Hello>123
</Hello>
123
---
Expand All @@ -100,68 +102,94 @@ printWidth: 80
</Hello>
<Hello>
test <World /> test
</Hello>123
</Hello>
123
---
<Hello>
test <World /> test
</Hello> 123
</Hello>
123
<Hello>
test <World /> test
</Hello> 234
</Hello>
234
---
<>
test <World /> test
</> 123
</>
123
---
| Column 1 | Column 2 |
|---|---|
| Text | <Hello>Text</Hello> |
---
<Hello attr={{ ab: 'cd'}} />
---
Hello, { javascript . expression }!
=====================================output=====================================
<Heading hi='there'>Hello, world!
<Heading hi="there">
Hello, world!
</Heading>
Comment on lines +141 to 143
Copy link
Collaborator Author
@seiyab seiyab Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSX elements are somewhat printed pretty because our mdx printer handles nodes like mdxJsxFlowElement.

---
<Hello>
test <World /> test
</Hello>123
test <World /> test
</Hello>
123
---
<Hello>
test <World /> test
test <World /> test
</Hello>
<Hello>
test <World /> test
</Hello>123
test <World /> test
</Hello>
123
---
<Hello>
test <World /> test
</Hello> 123
test <World /> test
</Hello>
123
<Hello>
test <World /> test
</Hello> 234
test <World /> test
</Hello>
234
---
<>
test <World /> test
</> 123
test <World /> test
</>
123
---
| Column 1 | Column 2 |
| -------- | ------------------- |
| Text | <Hello>Text</Hello> |
---
<Hello attr={{ ab: 'cd'}} />
---
Hello, {javascript . expression}!
================================================================================
`;
26 changes: 20 additions & 6 deletions tests/format/misc/embedded_language_formatting/mdx/jsx.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
<Heading hi='there'>Hello, world!
<Heading hi='there'>
Hello, world!
</Heading>

---

<Hello>
test <World /> test
</Hello>123
</Hello>
123

---

Expand All @@ -14,25 +16,37 @@
</Hello>
<Hello>
test <World /> test
</Hello>123
</Hello>
123

---

<Hello>
test <World /> test
</Hello> 123
</Hello>
123
<Hello>
test <World /> test
</Hello> 234
</Hello>
234

---

<>
test <World /> test
</> 123
</>
123

---

| Column 1 | Column 2 |
|---|---|
| Text | <Hello>Text</Hello> |

---

<Hello attr={{ ab: 'cd'}} />

---

Hello, { javascript . expression }!
20 changes: 16 additions & 4 deletions tests/unit/__snapshots__/visitor-keys.js.snap
View file
C835 Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1617,15 +1617,14 @@ exports[`visitor keys remark 1`] = `
],
"break": [],
"code": [],
"comment": [],
"definition": [],
"delete": [
"children",
],
"emphasis": [
"children",
],
"esComment": [],
"export": [],
"footnote": [
"children",
],
Expand All @@ -1639,10 +1638,8 @@ exports[`visitor keys remark 1`] = `
"html": [],
"image": [],
"imageReference": [],
"import": [],
"inlineCode": [],
"inlineMath": [],
"jsx": [],
"link": [
"children",
],
Expand All @@ -1657,6 +1654,21 @@ exports[`visitor keys remark 1`] = `
"children",
],
"math": [],
"mdxFlowExpression": [],
"mdxJsxAttribute": [
"value",
],
"mdxJsxAttributeValueExpression": [],
"mdxJsxFlowElement": [
"attributes",
"children",
],
"mdxJsxTextElement": [
"attributes",
"children",
],
"mdxTextExpression": [],
"mdxjsEsm": [],
"paragraph": [
"children",
],
Expand Down
Loading
0