E52B [MDX] All test pass by seiyab · Pull Request #18936 · prettier/prettier · GitHub
[go: up one dir, main page]

Skip to content

[MDX] All test pass#18936

Open
seiyab wants to merge 3 commits intoprettier:mdxfrom
seiyab:mdx-work-7
Open

[MDX] All test pass#18936
seiyab wants to merge 3 commits intoprettier:mdxfrom
seiyab:mdx-work-7

Conversation

@seiyab
Copy link
Collaborator
@seiyab seiyab commented Mar 11, 2026

Description

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Comment on lines -87 to +88
<Heading hi='there'>Hello, world!
<Heading hi='there'>
Hello, world!
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New parser can't parse the previous input.

@pkg-pr-new
Copy link
pkg-pr-new bot commented Mar 11, 2026

Open in StackBlitz

yarn add https://pkg.pr.new/@prettier/plugin-hermes@18936.tgz
yarn add https://pkg.pr.new/@prettier/plugin-oxc@18936.tgz
yarn add https://pkg.pr.new/prettier@18936.tgz

commit: 8270cb8

@netlify
Copy link
netlify bot commented Mar 11, 2026

Deploy Preview for prettier ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a152716
🔍 Latest deploy log https://app.netlify.com/projects/prettier/deploys/69b17a9d4e60ee000842865c
😎 Deploy Preview https://deploy-preview-18936--prettier.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment on lines +141 to 143
<Heading hi="there">
Hello, world!
</Heading>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSX elements are somewhat printed pretty because our mdx printer handles nodes like mdxJsxFlowElement.

Copy link
Member
@fisker fisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0