-
Notifications
You must be signed in to change notification settings - Fork 452
chore: updated podman to v5.6.0 #13624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Marcel Bertagnini <mbertagn@redhat.com>
📝 WalkthroughWalkthroughBumps Podman version references from 5.5.2 to 5.6.0 in extensions/podman/packages/extension/src/podman5.json. Updates the root version, releaseNotes href, Windows installer filename to podman-5.6.0-setup.exe, and macOS installer filenames for x64, arm64, and universal variants to v5.6.0 .pkg names. No other files or exported/public declarations changed. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Marcel Bertagnini <mbertagn@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
extensions/podman/packages/extension/src/podman5.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: unit tests / macos-15
- GitHub Check: typecheck
- GitHub Check: linter, formatters
- GitHub Check: unit tests / windows-2025
- GitHub Check: build website
- GitHub Check: unit tests / ubuntu-24.04
- GitHub Check: smoke e2e tests (production)
- GitHub Check: macOS
- GitHub Check: smoke e2e tests (development)
- GitHub Check: Linux
- GitHub Check: Windows
🔇 Additional comments (1)
extensions/podman/packages/extension/src/podman5.json (1)
2-2
: Version bump to 5.6.0 looks goodTop-level version updated correctly.
"version": "v5.6.0", | ||
"fileName": "podman-5.6.0-setup.exe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Validate asset filenames exist in the v5.6.0 release
The platform versions and filenames look correct. To avoid runtime 404s, verify that these assets exist for tag v5.6.0 on GitHub.
Also applies to: 12-21
🏁 Script executed:
#!/bin/bash
set -euo pipefail
TAG="v5.6.0"
OWNER="containers"
REPO="podman"
expected=(
"podman-5.6.0-setup.exe"
"podman-installer-macos-amd64-v5.6.0.pkg"
"podman-installer-macos-aarch64-v5.6.0.pkg"
"podman-installer-macos-universal-v5.6.0.pkg"
)
echo "Fetching assets for ${OWNER}/${REPO} tag ${TAG}..."
names=$(curl -fsSL "https://api.github.com/repos/${OWNER}/${REPO}/releases/tags/${TAG}" | jq -r '.assets[].name')
echo "Assets published:"
printf '%s\n' "$names" | sed 's/^/ - /'
missing=()
for f in "${expected[@]}"; do
if ! printf '%s\n' "$names" | grep -Fxq "$f"; then
missing+=("$f")
fi
done
if ((${#missing[@]})); then
echo "Missing expected assets:"
printf ' - %s\n' "${missing[@]}"
exit 1
else
echo "All expected assets are present."
fi
Length of output: 4503
Incorrect macOS asset filenames in podman5.json
The JSON references three macOS packages with embedded -v5.6.0
suffixes that don’t exist on GitHub. The actual assets published under v5.6.0
are:
- podman-installer-macos-amd64.pkg
- podman-installer-macos-arm64.pkg
- podman-installer-macos-universal.pkg
Please update your entries in extensions/podman/packages/extension/src/podman5.json
(lines 12–21) accordingly. For example:
{
"platform": "macos-amd64",
- "fileName": "podman-installer-macos-amd64-v5.6.0.pkg"
+ "fileName": "podman-installer-macos-amd64.pkg"
},
{
"platform": "macos-aarch64",
- "fileName": "podman-installer-macos-aarch64-v5.6.0.pkg"
+ "fileName": "podman-installer-macos-arm64.pkg"
},
{
"platform": "macos-universal",
- "fileName": "podman-installer-macos-universal-v5.6.0.pkg"
+ "fileName": "podman-installer-macos-universal.pkg"
},
This will prevent runtime 404 errors when downloading the macOS installers.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"version": "v5.6.0", | |
"fileName": "podman-5.6.0-setup.exe" | |
{ | |
"platform": "macos-amd64", | |
"fileName": "podman-installer-macos-amd64.pkg" | |
}, | |
{ | |
"platform": "macos-aarch64", | |
"fileName": "podman-installer-macos-arm64.pkg" | |
}, | |
{ | |
"platform": "macos-universal", | |
"fileName": "podman-installer-macos-universal.pkg" | |
}, |
🤖 Prompt for AI Agents
In extensions/podman/packages/extension/src/podman5.json around lines 12–21, the
macOS asset filenames incorrectly include a "-v5.6.0" suffix that doesn’t exist
on GitHub; replace those three macOS entries with the actual asset names
podman-installer-macos-amd64.pkg, podman-installer-macos-arm64.pkg, and
podman-installer-macos-universal.pkg (remove the "-v5.6.0" suffix) so the JSON
points to the correct published installers and avoids 404s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and created #13626 for future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise LGTM
* chore: updated podman to v5.6.0 Signed-off-by: Marcel Bertagnini <mbertagn@redhat.com> * chore: updated missing ref to new podman v5.6.0 Signed-off-by: Marcel Bertagnini <mbertagn@redhat.com> --------- Signed-off-by: Marcel Bertagnini <mbertagn@redhat.com>
What does this PR do?
Update Podman to v5.6.0
https://github.com/containers/podman/releases/tag/v5.6.0
Screenshot / video of UI
What issues does this PR fix or reference?
closes #13427
How to test this PR?