-
Notifications
You must be signed in to change notification settings - Fork 452
chore: update podman to v5.5.2 #12960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fixes #12959 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 WalkthroughWalkthroughThe changes update the Podman extension version from 5.5.1 to 5.5.2 in the JSON configuration file located at extensions/podman/packages/extension/src/podman5.json. All version references, including the release notes URL and installer filenames for Windows and macOS (x64, arm64, universal), have been modified to reflect the new 5.5.2 version. No changes to code logic or exported entities were made. Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes were found. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
extensions/podman/packages/extension/src/podman5.json (1)
2-22
: Mind the mixed use of thev
prefix in version strings.The top-level
"version"
is"5.5.2"
(nov
), while every platform-specific"version"
keeps thev
prefix ("v5.5.2"
).
If downstream tooling parses these fields programmatically it may need extra handling for the mismatch.Consider normalising the prefix across all version fields (either add
v
to the top level or drop it from the nested ones) unless consumers explicitly rely on the current convention.
No functional issue, just a consistency concern.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
extensions/podman/packages/extension/src/podman5.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (11)
- GitHub Check: typecheck
- GitHub Check: build website
- GitHub Check: linter, formatters
- GitHub Check: macOS
- GitHub Check: smoke e2e tests (production)
- GitHub Check: unit tests / ubuntu-24.04
- GitHub Check: smoke e2e tests (development)
- GitHub Check: unit tests / macos-15
- GitHub Check: unit tests / windows-2022
- GitHub Check: Windows
- GitHub Check: Linux
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
What does this PR do?
update podman to v5.5.2
https://github.com/containers/podman/releases/tag/v5.5.2
Screenshot / video of UI
What issues does this PR fix or reference?
fixes #12959
How to test this PR?