10000 Drop contourgl and pointcloud traces from the code and API by archmoj · Pull Request #5398 · plotly/plotly.js · GitHub
[go: up one dir, main page]

Skip to content

Drop contourgl and pointcloud traces from the code and API #5398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
10000 Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reimplement heatmapgl
  • Loading branch information
archmoj committed Jan 14, 2021
commit 530281a439a51896167b3c9a01c9ec86b5ff7a83
11 changes: 11 additions & 0 deletions lib/heatmapgl.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
/**
* Copyright 2012-2021, Plotly, Inc.
* All rights reserved.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

'use strict';

module.exports = require('../src/traces/heatmapgl');
1 change: 1 addition & 0 deletions lib/index-gl2d.js
Original file line number Diff line number Diff line change
10000 Expand Up @@ -13,6 +13,7 @@ var Plotly = require('./core');
Plotly.register([
require('./scattergl'),
require('./splom'),
require('./heatmapgl'),
require('./parcoords')
]);

Expand Down
2 changes: 2 additions & 0 deletions lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ Plotly.register([
require('./scattergl'),
require('./splom'),

require('./heatmapgl'),

require('./parcoords'),

require('./parcats'),
Expand Down
245 changes: 222 additions & 23 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,15 @@
"fast-isnumeric": "^1.1.4",
"gl-cone3d": "^1.5.2",
"gl-error3d": "^1.0.16",
"gl-heatmap2d": "^1.1.0",
"gl-line3d": "1.2.1",
"gl-mat4": "^1.2.0",
"gl-mesh3d": "^2.3.1",
"gl-plot2d": "^1.4.5",
"gl-plot3d": "^2.4.7",
"gl-pointcloud2d": "^1.0.3",
"gl-scatter3d": "^1.2.3",
"gl-select-box": "^1.0.4",
"gl-spikes2d": "^1.0.2",
"gl-streamtube3d": "^1.4.1",
"gl-surface3d": "^1.6.0",
"gl-text": "^1.1.8",
Expand Down
1 change: 1 addition & 0 deletions src/components/images/draw.js
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ module.exports = function draw(gd) {
var subplotObj = fullLayout._plots[subplot];

// filter out overlaid plots (which have their images on the main plot)
// and heatmapgl plots (which don't support below images, at least not yet)
if(!subplotObj.imagelayer) continue;

var imagesOnSubplot = subplotObj.imagelayer.selectAll('image')
Expand Down
11 changes: 11 additions & 0 deletions src/components/modebar/buttons.js
Original file line number Diff line number Diff line change
Expand Up @@ -544,6 +544,17 @@ function handleGeo(gd, ev) {
}
}

modeBarButtons.hoverClosestGl2d = {
name: 'hoverClosestGl2d',
title: function(gd) { return _(gd, 'Toggle show closest data on hover'); },
attr: 'hovermode',
val: null,
toggle: true,
icon: Icons.tooltip_basic,
gravity: 'ne',
click: toggleHover
};

modeBarButtons.hoverClosestPie = {
name: 'hoverClosestPie',
title: function(gd) { return _(gd, 'Toggle show closest data on hover'); },
Expand Down
Loading
0