Drop contourgl and pointcloud traces from the code and API #5398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is dropping |
In the following commits, we could attempt maintaining |
Please let us not do this. We should be dropping We can talk about dropping heatmapgl in the meeting tomorrow if you like. |
- namely pointcloud, contourgl and heatmapgl - one could use image & scattergl instaed of heatmapgl & pointcloud - this very much cleans the gl2d bundle from bugs & function constructors - with the exception of binary-search-bounds v2 used in scattergl now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4962 while addressing #5395 & #897.
The first commit 881c417
cleaned up
pointcloud,contourgl,heatmapgltraces as well asgl2dsubplots.The second commit 530281a re-implemented
heatmapglwhile adding notes considering thatheatmapglis the only trace left usingplots/gl2dand notplots/cartesian.So I won't be surprised if one could optimize files in
plots/gl2dor modules e.g.gl-plot2d v1.4.5,gl-select-box v^1.0.4andgl-spikes2d v1.0.2.@plotly/plotly_js