lint

plotly · etpinard · Nov 16, 2015 · Nov 11, 2015 · Nov 15, 2015 · Nov 15, 2015
commit dc28064ffb1328fc519ee4d9c83ebd5324eb467e
diff --git a/src/components/modebar/index.js b/src/components/modebar/index.js
@@ -450,14 +450,14 @@ proto.toImage = function() {
 
     var ev = Plotly.Snapshot.toImage(this.graphInfo, {format: format});
 
-    var filename = this.graphInfo.fn || "newplot";
+    var filename = this.graphInfo.fn || 'newplot';
     filename += '.' + format;
 
     ev.once('success', function(result) {
 
         _this._snapshotInProgress = false;
 
-        var downloadLink = document.createElement("a");
+        var downloadLink = document.createElement('a');
         downloadLink.href = result;
         downloadLink.download = filename; // only supported by FF and Chrome
 

diff --git a/src/lib/events.js b/src/lib/events.js
@@ -1,5 +1,7 @@
 'use strict';
 
+/* global $:false */
+
 var EventEmitter = require('events').EventEmitter;
 
 var Events = {

diff --git a/src/plots/geo/projections.js b/src/plots/geo/projections.js
@@ -1,3 +1,14 @@
+// jshint ignore: start
+
+/**
+ * Forked from https://github.com/d3/d3-geo-projection
+ * Pasted from https://github.com/etpinard/d3-geo-projection
+ *
+ * Containing only the 'most useful' projection types
+ * and compatible with CommonJs
+ *
+ */
+
 var d3 = require('d3');
 
 function addProjectionToD3() {
@@ -61,7 +72,7 @@ function addProjectionToD3() {
       d3_geo_projectPoints.push([ x, y ]);
     },
     lineEnd: function() {
-      if (d3_geo_projectPoints.length) d3_geo_projectLines.push(d3_geo_projectPoints), 
+      if (d3_geo_projectPoints.length) d3_geo_projectLines.push(d3_geo_projectPoints),
       d3_geo_projectPoints = [];
     },
     result: function() {
@@ -188,7 +199,7 @@ function addProjectionToD3() {
     };
     var projection = d3.geo.projection(forward), stream_ = projection.stream;
     projection.stream = function(stream) {
-      var rotate = projection.rotate(), rotateStream = stream_(stream), sphereStream = (projection.rotate([ 0, 0 ]), 
+      var rotate = projection.rotate(), rotateStream = stream_(stream), sphereStream = (projection.rotate([ 0, 0 ]),
       stream_(stream));
       projection.rotate(rotate);
       rotateStream.sphere = function() {

diff --git a/src/plots/gl3d/camera.js b/src/plots/gl3d/camera.js
@@ -221,7 +221,7 @@ function createCamera(element, options) {
     return true;
   });
 
-  mouseWheel(element, function(dx, dy, dz) {
+  mouseWheel(element, function(dx, dy) {
     var flipX = camera.flipX ? 1 : -1;
     var flipY = camera.flipY ? 1 : -1;
     var t = now();

diff --git a/src/plots/polar/micropolar.js b/src/plots/polar/micropolar.js
@@ -1,3 +1,5 @@
+// jshint ignore: start
+
 var Plotly = require('../../plotly');
 var d3 = require('d3');
 

diff --git a/src/plots/polar/undo_manager.js b/src/plots/polar/undo_manager.js
@@ -1,3 +1,5 @@
+// jshint ignore: start
+
 'use strict';
 
 //Modified from https://github.com/ArthurClemens/Javascript-Undo-Manager

diff --git a/src/traces/boxes/index.js b/src/traces/boxes/index.js
@@ -75,7 +75,7 @@ boxes.supplyDefaults = function(traceIn, traceOut, defaultColor) {
         coerce('marker.line.width');
 
         if(boxpoints==='suspectedoutliers') {
-            coerce('marker.line.outliercolor', traceOut.marker.color)
+            coerce('marker.line.outliercolor', traceOut.marker.color);
             coerce('marker.line.outlierwidth');
         }
     }

diff --git a/src/traces/histogram/attributes.js b/src/traces/histogram/attributes.js
@@ -1,3 +1,5 @@
+'use strict';
+
 var barAttrs = require('../bars/attributes');
 
 

diff --git a/src/traces/scatter3d/convert.js b/src/traces/scatter3d/convert.js
@@ -70,7 +70,9 @@ function constructDelaunay(points, color, axis) {
     var v = (axis+2)%3;
     var filteredPoints = [];
     var 
6E3B
filteredIds    = [];
-    for(var i=0; i<points.length; ++i) {
+    var i;
+
+    for(i=0; i<points.length; ++i) {
         var p = points[i];
         if(isNaN(p[u]) || !isFinite(p[u]) ||
            isNaN(p[v]) || !isFinite(p[v])) {
@@ -80,7 +82,7 @@ function constructDelaunay(points, color, axis) {
         filteredIds.push(i);
     }
     var cells = triangulate(filteredPoints);
-    for(var i=0; i<cells.length; ++i) {
+    for(i=0; i<cells.length; ++i) {
         var c = cells[i];
         for(var j=0; j<c.length; ++j) {
             c[j] = filteredIds[c[j]];
Original file line number	Diff line number	Diff line change
		@@ -1,3 +1,5 @@
		'use strict';

		var barAttrs = require('../bars/attributes');


Expand Down