10000 More consistent geo maps configs by etpinard · Pull Request #4 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

More consistent geo maps configs #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etpinard merged 16 commits into from
Nov 16, 2015
Merged

More consistent geo maps configs #4

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
cebfb46
attach geo zoom reset handler to 'dblclick.zoom' (not 'zoom'):
etpinard Nov 11, 2015
8cf43fd
Merge branch 'reorg-src' into fix-d3-geo-dblclick
etpinard Nov 15, 2015
2d34efe
add 'topojsonURL' plot config option
etpinard Nov 15, 2015
524b6dd
replace PLOTLYENV topojson url setting with 'topojsonURL' config opt
etpinard Nov 15, 2015
8b9a609
rm hard topojson assets:
etpinard Nov 15, 2015
40c7549
add preprocess step to copy topojson assets to dist/
etpinard Nov 15, 2015
9afb014
grab topojson from PlotlyGeoAssets.topojson
etpinard Nov 15, 2015
55b9336
use local topojson from dist/ in test dahsboard
etpinard Nov 15, 2015
65a64c4
rename pathToTopojsonDest constant -> pathToTopojsonDist
etpinard Nov 15, 2015
584f611
Merge branch 'master' into fix-d3-geo-dblclick
etpinard Nov 16, 2015
dc28064
lint
etpinard Nov 16, 2015
bf971d6
Revert "rm check for Plotly.Queue:"
etpinard Nov 16, 2015
a580000
expose Queue as part of the 'unofficial' api
etpinard Nov 16, 2015
c14040b
rename graph_obj_test -> plot_api_test
etpinard Nov 16, 2015
6d6ba54
make watchified bundle step output plotly.js in build/:
etpinard Nov 16, 2015
050e53b
new dist
etpinard Nov 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
grab topojson from PlotlyGeoAssets.topojson
  • Loading branch information
@etpinard
etpinard committed Nov 15, 2015
commit 9afb0148dd343af0b52eb47e75eb57131daa86d5
6 changes: 3 additions & 3 deletions src/plot_api/plot_api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,10 +455,10 @@ function plotGeo(gd) {

var i, geoId, fullGeoData, geo;

// if plotlyjs-geo-assets-bundle is not included,
// initialize object to keep reference to every loaded topojsons
// if 'plotly-geo-assets.js' is not included,
// initialize object to keep reference to every loaded topojson
if(window.PlotlyGeoAssets === undefined) {
window.PlotlyGeoAssets = { topojsons : {} };
window.PlotlyGeoAssets = { topojson : {} };
}

for (i = 0; i < geoIds.length; i++) {
Expand Down
6 changes: 3 additions & 3 deletions src/plots/geo/geo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ proto.plot = function(geoData, fullLayout) {
if(_this.topojson===null || topojsonNameNew!==_this.topojsonName) {
_this.topojsonName = topojsonNameNew;

if(PlotlyGeoAssets.topojsons[_this.topojsonName] !== undefined) {
_this.topojson = PlotlyGeoAssets.topojsons[_this.topojsonName];
if(PlotlyGeoAssets.topojson[_this.topojsonName] !== undefined) {
_this.topojson = PlotlyGeoAssets.topojson[_this.topojsonName];
_this.onceTopojsonIsLoaded(geoData, geoLayout);
}
else {
Expand All @@ -94,7 +94,7 @@ proto.plot = function(geoData, fullLayout) {
// N.B this is async
d3.json(topojsonPath, function(error, topojson) {
_this.topojson = topojson;
PlotlyGeoAssets.topojsons[_this.topojsonName] = topojson;
PlotlyGeoAssets.topojson[_this.topojsonName] = topojson;
_this.onceTopojsonIsLoaded(geoData, geoLayout);
});
}
Expand Down
0