-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Feature: Range selectors #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
36968ad
first pass range selector attributes
etpinard ab6c109
first pass range selector defaults
etpinard 19d81d4
first pass range selector draw method
etpinard aa84cf0
add 'buttons' to list of non-data array in the plot-schema
etpinard b5e8301
ensure that range selector attributes are only coerced for date axes
etpinard 80c75c7
pull off update object logic into seperate file:
etpinard f25213d
put range selector on-par with legend's
etpinard ef64e20
move RangeSelector.draw to just after Legend.draw
etpinard 26494cf
make range selector border width dflt 1
etpinard da47cd4
tmp commit (range selector draw)
etpinard da71911
make range selector module more like range slider:
etpinard ab27021
first pass range selector attributes
etpinard de5e6b3
first pass range selector defaults
etpinard e976877
first pass range selector draw method
etpinard 3fde2f8
add 'buttons' to list of non-data array in the plot-schema
etpinard 121231b
ensure that range selector attributes are only coerced for date axes
etpinard 8c839a1
pull off update object logic into seperate file:
etpinard 48b5c50
put range selector on-par with legend's
etpinard 4c7c99d
move RangeSelector.draw to just after Legend.draw
etpinard b198529
make range selector border width dflt 1
etpinard 17c8377
tmp commit (range selector draw)
etpinard 0d20931
make range selector module more like range slider:
etpinard b9e388f
better text positioning in range-select buttons
mdtusz a5e6aaa
Merge branch 'range-selector' of https://github.com/plotly/plotly.js …
mdtusz 86331c7
lint in Plots.autoMargin
etpinard c9f76ab
add positionning logic to range selector draw step
etpinard 574a6b3
change default yanchor to 'bottom'
etpinard beb239b
fixup test description
etpinard ec0771a
use new Date() to def specs instead of ms:
etpinard dd4880b
make y position 1.02 by default
etpinard 2264bdd
add 'hour', 'minute' and 'second' button step values
etpinard f11aef9
Update rangeselector attributes
mdtusz 8b4340e
don't coerce 'stepmode' and 'count' when 'step' is set to 'all'
etpinard 053be81
handle to-date with step > 1 case
etpinard f49dd51
handle step 'all' case in label text
etpinard fb056b1
add range selector image mock
etpinard b2988b4
add a few range selector interaction tests
etpinard 3a812c9
make getUpdateObject use ax._name to build update object
etpinard 1ca424a
fixup test (to accomodate new defaults)
etpinard a671683
add smart default for range selector 'x' and 'y':
etpinard 1042f4f
get range selector attributes ready for plot schema:
etpinard 46f4a20
add comment about plotly.py in isLinkedToArray plot schema test
etpinard 616d77d
add 'rx' and 'ry' button rect radii
etpinard 86a3167
pass axis name to Plots.autoMargin,
etpinard 4318f45
fix default label text generator
etpinard f025dc6
add is-active and is-hovered dynamic props to buttons:
etpinard ade535e
fixup attribute descriptions
etpinard 49507be
change range selector and slider 'borderwidth' dflt to 0.
etpinard c95b45a
update range selector image test + add one more
etpinard 6a68155
add is-active button update test
etpinard 1275935
rename 'to date' stepmode 'todate'
etpinard 6c3a9d7
update image mock 'to date' -> 'todate'
etpinard 6da24e4
update default button style:
etpinard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add 'rx' and 'ry' button rect radii
- Loading branch information
commit 616d77d6c23b9d7915d4ead51653d0a126817176
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we plan to make this configurable later (and if people ask)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. When enough people ask.