Feature: Range selectors #373
Conversation
- so that it can be separatly tested.
- change directory name to rangeselector (instead of range_selector) - rename default func supplyLayoutDefaults (instead of supplyDefaults) - require full module into cartesian defaults
- so that it can be separatly tested.
- change directory name to rangeselector (instead of range_selector) - rename default func supplyLayoutDefaults (instead of supplyDefaults) - require full module into cartesian defaults
…into range-selector
- so that it works in all time zones - and to make things more readable
- based off corresponding xaxis and yaxis domain
- use isLinkedToArray to describe 'buttons' - crawl through layout attribute to convert all isLinkedToArray attributes to items object that plotly.py can parse - fill in missing descriptions - link range selector attributes in axis attributes
| dflt: 'left', | ||
| role: 'info', | ||
| description: [ | ||
| 'Sets the range selector \'s horizontal position anchor.', |
- so that running auto-margin on multiple selectors does not result in an infinite loop
- use update object and current axis range to determine whether a given button is active - fill button with Color.ligthLine on mouse over and when active.
| expect(itemObj.role).toBe('object'); | ||
|
|
||
| var role = np.get().role; | ||
| expect(role).toEqual('object'); |
There was a problem hiding this comment.
@cldougl @theengineear ⏫ needs to be satisfied for plotly.py to build to correct graph object.
There was a problem hiding this comment.
@delekru https://github.com/delekru @etpinard @chriddyp
Can we please use Highchart's button styling? I think they did a good job
and its what users are familiar with:
http://www.highcharts.com/stock/demo/basic-line
On Fri, Apr 1, 2016 at 4:20 PM, Étienne Tétreault-Pinard <
notifications@github.com> wrote:
In test/jasmine/tests/plotschema_test.js
#373 (comment):
);
var name = np.parts[np.parts.length - 1],itemName = name.substr(0, name.length - 1);
var itemsObj = np.get().items,itemObj = itemsObj[itemName];
expect(isPlainObject(itemsObj)).toBe(true);expect(itemsObj.role).toBeUndefined();expect(Object.keys(itemsObj).length).toEqual(1);expect(isPlainObject(itemObj)).toBe(true);expect(itemObj.role).toBe('object');
var role = np.get().role;expect(role).toEqual('object');@cldougl https://github.com/cldougl @theengineear
https://github.com/theengineear [image: ⏫] needs to be
satisfied for plotly.py to build to correct graph object.—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/plotly/plotly.js/pull/373/files/a671683931ac3856674bce3af7b5d988c0857cb5..1042f4f656c3e1ac14a365477a93c6d66d44b855#r58269266
- default style has fill with Color.lightLine - active and hovered over buttons are shown in a darker grey (#d3d3d3)
| stepmode: { | ||
| valType: 'enumerated', | ||
| role: 'info', | ||
| values: ['backward', 'todate'], |
There was a problem hiding this comment.
Should there be a forwards mode?
There was a problem hiding this comment.
maybe. HighCharts doesn't support it, so I didn't put it in the first iteration.
resolves #207.
@mdtusz @chriddyp @cldougl @alexcjohnson @jackparmer
Strongly inspired by http://api.highcharts.com/highstock#rangeSelector
Example
Given a time series, the following layout:
gives
Limitations
xaxes with type'date'(can be auto-typed)label