8000 Emit 'plotly_afterplot' on all edits by etpinard · Pull Request #2773 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Emit 'plotly_afterplot' on all edits #2773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 5, 2018
Merged

Emit 'plotly_afterplot' on all edits #2773

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95cf27a
no need to export lsInner
etpinard Jul 4, 2018
37c602a
emit 'plotly_afterplot' after edit types
etpinard Jul 4, 2018
22a07a9
adapt plot_api test to corrected plotly_afterplot behavior
etpinard Jul 4, 2018
cb92d7c
emit 'plotly_afterplot' once during doAutoMargin redraws
etpinard Jul 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
8000
Diff view
Next Next commit
no need to export lsInner
  • Loading branch information
@etpinard
etpinard committed Jul 4, 2018
commit 95cf27aa901aa5c80b435e2db2baaa5bcec78fce
6 changes: 3 additions & 3 deletions src/plot_api/subroutines.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ var cleanAxisConstraints = axisConstraints.clean;
var doAutoRange = require('../plots/cartesian/autorange').doAutoRange;

exports.layoutStyles = function(gd) {
return Lib.syncOrAsync([Plots.doAutoMargin, exports.lsInner], gd);
return Lib.syncOrAsync([Plots.doAutoMargin, lsInner], gd);
};

function overlappingDomain(xDomain, yDomain, domains) {
Expand All @@ -46,7 +46,7 @@ function overlappingDomain(xDomain, yDomain, domains) {
return false;
}

exports.lsInner = function(gd) {
function lsInner(gd) {
var fullLayout = gd._fullLayout;
var gs = fullLayout._size;
var pad = gs.p;
Expand Down Expand Up @@ -327,7 +327,7 @@ exports.lsInner = function(gd) {
ModeBar.manage(gd);

return gd._promises.length && Promise.all(gd._promises);
};
}

function findMainSubplot(ax, fullLayout) {
var subplotList = fullLayout._subplots;
Expand Down
0