8000 Emit 'plotly_afterplot' on all edits by etpinard · Pull Request #2773 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Emit 'plotly_afterplot' on all edits #2773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 5, 2018
Merged

Emit 'plotly_afterplot' on all edits #2773

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95cf27a
no need to export lsInner
etpinard Jul 4, 2018
37c602a
emit 'plotly_afterplot' after edit types
etpinard Jul 4, 2018
22a07a9
adapt plot_api test to corrected plotly_afterplot behavior
etpinard Jul 4, 2018
cb92d7c
emit 'plotly_afterplot' once during doAutoMargin redraws
etpinard Jul 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
emit 'plotly_afterplot' after edit types
  • Loading branch information
@etpinard
etpinard committed Jul 4, 2018
commit 37c602a21cf265a3e255c0b9f8613100a92785d2
14 changes: 12 additions & 2 deletions src/plot_api/plot_api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ exports.plot = function(gd, data, layout, config) {
Plots.supplyDefaults(gd);

var fullLayout = gd._fullLayout;

var hasCartesian = fullLayout._has('cartesian');

// Legacy polar plots
Expand Down Expand Up @@ -375,11 +374,15 @@ exports.plot = function(gd, data, layout, config) {
if(!plotDone || !plotDone.then) plotDone = Promise.resolve();

return plotDone.then(function() {
gd.emit('plotly_afterplot');
emitAfterPlot(gd);
return gd;
});
};

function emitAfterPlot(gd) {
gd.emit('plotly_afterplot');
}

exports.setPlotConfig = function setPlotConfig(obj) {
return Lib.extendFlat(defaultConfig, obj);
};
Expand Down Expand Up @@ -1327,6 +1330,8 @@ exports.restyle = function restyle(gd, astr, val, _traces) {

if(flags.style) seq.push(subroutines.doTraceStyle);
if(flags.colorbars) seq.push(subroutines.doColorBars);

seq.push(emitAfterPlot);
}

seq.push(Plots.rehover);
Expand Down Expand Up @@ -1704,6 +1709,8 @@ exports.relayout = function relayout(gd, astr, val) {
if(flags.ticks) seq.push(subroutines.doTicksRelayout);
if(flags.modebar) seq.push(subroutines.doModeBar);
if(flags.camera) seq.push(subroutines.doCamera);

seq.push(emitAfterPlot);
}

seq.push(Plots.rehover);
Expand Down Expand Up @@ -2191,6 +2198,8 @@ exports.update = function update(gd, traceUpdate, layoutUpdate, _traces) {
if(relayoutFlags.ticks) seq.push(subroutines.doTicksRelayout);
if(relayoutFlags.modebar) seq.push(subroutines.doModeBar);
if(relayoutFlags.camera) seq.push(subroutines.doCamera);

seq.push(emitAfterPlot);
}

seq.push(Plots.rehover);
Expand Down Expand Up @@ -2348,6 +2357,7 @@ exports.react = function(gd, data, layout, config) {
if(relayoutFlags.ticks) seq.push(subroutines.doTicksRelayout);
if(relayoutFlags.modebar) seq.push(subroutines.doModeBar);
if(relayoutFlags.camera) seq.push(subroutines.doCamera);
seq.push(emitAfterPlot);
}

seq.push(Plots.rehover);
Expand Down
0