8000 fix: address various check/test/CI issues by cpsievert · Pull Request #2441 · plotly/plotly.R · GitHub
[go: up one dir, main page]
Skip to content

fix: address various check/test/CI issues #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 5, 2025
Merged

fix: address various check/test/CI issues #2441

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
70b4590
Follow up to #1999: update test expectation to not expect warning
cpsievert Jun 5, 2025
69a81ec
Temporarily test against CRAN ggplot2
cpsievert Jun 5, 2025
009f44e
Avoid :: on old ggplot2 function
cpsievert Jun 5, 2025
cd3ed84
Disable oldrel-4; roxygen stuff
cpsievert Jun 5, 2025
ac8dd2d
Update URL
cpsievert Jun 5, 2025
04cbc37
Try to fix kaliedo install
cpsievert Jun 5, 2025
a0cda2a
Fix more roxygen issues
cpsievert Jun 5, 2025
01e73fb
Pass data to use_defaults() method (this way GeomSf default aes logic…
cpsievert Jun 5, 2025
0507b76
Approve new snapshots
cpsievert Jun 5, 2025
b7d38c0
Revert "Pass data to use_defaults() method (this way GeomSf default a…
cpsievert Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Follow up to #1999: update test expectation to not expect warning
  • Loading branch information
@cpsievert
cpsievert committed Jun 5, 2025
commit 70b459041f9b9bfb70583cad38a9c9043288ffa8
3 changes: 1 addition & 2 deletions tests/testthat/test-plotly.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,7 @@ test_that("Character strings correctly mapped to a positional axis", {
letters <- LETTERS[as.numeric(sort(as.character(1:26)))]
p <- plot_ly(x = letters, y = seq_along(letters)) %>%
add_bars(color = rep(c("a1", "a2"), length.out = 26))
l <- expect_warning(expect_traces(p, 2, "character-axis"),
regexp = "minimal value for n is 3")
l <- expect_traces(p, 2, "character-axis")
expect_equivalent(l$layout$xaxis$type, "category")
expect_equivalent(l$layout$xaxis$categoryorder, "array")
expect_equivalent(l$layout$xaxis$categoryarray, LETTERS)
Expand Down
0