8000 fix: address various check/test/CI issues by cpsievert · Pull Request #2441 · plotly/plotly.R · GitHub
[go: up one dir, main page]
Skip to content

fix: address various check/test/CI issues #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 5, 2025
Merged

fix: address various check/test/CI issues #2441

merged 10 commits into from
Jun 5, 2025

Conversation

cpsievert
Copy link
Collaborator
@cpsievert cpsievert commented Jun 5, 2025 •
edited
Loading

Fixes some new GHA, R CMD check, roxygen, and testthat issues.

Also updates visual tests to match what you'd get with the current CRAN version of ggplot2 (v3.5.2).

NOTE: I'm not exactly sure what caused the difference in stroke in the sf baselines, but 01e73fb will fix the (unwanted) difference with the latest ggplot2 (coming in a follow up PR)

@cpsievert cpsievert changed the title Get tests passing Get tests passing with CRAN ggplot2 Jun 5, 2025
@cpsievert cpsievert changed the title Get tests passing with CRAN ggplot2 fix: address various check/test/CI issues Jun 5, 2025
@cpsievert cpsievert merged commit 3b5f6e6 into master Jun 5, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cpsievert
0