Add Discard (TRIM) option and NVME storage controller#186
Add Discard (TRIM) option and NVME storage controller#186h6w merged 6 commits intophpvirtualbox:developfrom chotaire:chot-discard-nvme
Conversation
|
I've done some tests and these features require a patched vboxServiceWrappers.php to work. @pasha1st has provided an updated vboxServiceWrappers.php from Oracle at #167. Unfortunately, this version breaks the important capability to create snapshots (see #177). I have thereby backported and tested the necessary changes to the following commit: |
|
I have tested these patches as working. Adding and removing TRIM option works, this option is properly saved to VM configuration. Trimming inside a guest will result in the VDI to be shrunk (tested with Linux and FreeBSD guests). Creating snapshots works again. |
|
You're really merging two features together in this PR, and there's an unrelated formatting change (spaces->tabs) probably caused by your editor. But, this is much easier to read than pasha1st's PR so I'll allow it this time..... |
This pull request adds NVME as available storage controller and the ability to select Discard (TRIM). Discard requires a VDI to be set as non-rotational (SSD). This will allow a VDI to shrink on the host if trim has been issued inside the guest. This would finally make an end to using zerofree, sdelete or dd to fill up the disk with zeroes before shutting down the VM and using vboxmanage modifymedium diskname.vdi --compact - which is a task that drives people away from VirtualBox.
Coded by @pasha1st - his pull request #167 got legitimately rejected due to several issues so I am lending a helping hand and split this into multiple pull requests. This needs tested and finally merged, we need to move forward.