VirtualBox 6.0.x adaptation#167
Conversation
|
Nice! Please merge :-) |
|
I'm afraid I can't accept pull requests that change the project URL and imply a non-phpvirtualbox group "adaptation". There are more changes here than a simple version upgrade, please break your merge request into sections to make the commit clearer. Thanks. |
|
Now I cleared url changes and other copyright canges
New options: It is hard to split all changes, and it is much more then "simple version upgrade" |
|
Yes, but the title of the push is "6.0.6 adaptation" which is what we expect to see. As much as we value your contribution, you have to understand from our point of view. Bundling feature changes together is bad because: phpvirtualbox is software which is rolled out to 1000s of machines each day and is frequently available publicly. As much as we value your contribution, we have to follow some processes to make all changes clear and understandable to everyone. Splitting your changes is not as hard as you think: |
|
One other note. Please don't edit the changelog. That's for us to do at release time. |
|
Could you maybe fix the RDP settings tab? I can't switch to this tab and edit the settings. Many thanks! |
|
Me, personally, would like to see @pasha1st contributions get into this repository. |
|
"Could you maybe fix the RDP settings tab? I can't switch to this tab and edit the settings. Many thanks!" That means you can't see the VM screens with that flash technology? |
|
Last time I checked, I couldn't configure the remote display settings as it was greyed out. I just checked again to make a screenshot, but it's now available. Sorry for the noise. |
|
OK, so you said now it works. Will try it, thank you very much!! ;-) |
|
where can i download it, was it (vb 6.0.x compatibilty feature) added to the master branch? |
|
yes, current dev branch seems to work with vb 6.0.x in general. important: don't forget to activate remote display pm port 9000-9100 if you used the windows vb gui for your vm before you used phpvirtualbox! |
|
but: why the remote screen always goes to 127.0.0.1? why is there no function like "getHostIPAddress" or something like that on php code?!?! That made a big mess, because i used a remote ip for phpvirtualbox and then the remote screen used 127.0.0.1 - and on my local pc, 127.0.0.1, was the same phpvirtualbox installation too - very confusing!!!!!!!!!!! |
|
Hope to see the merge, which adds a lot of features support :) |
|
Can someone please, marge or close this one? |
|
The issues have been made clear above. So I'm closing it. |
VirtualBox 6.0.x adoptation with major VB6 features support
Please note README and About changes when merge