feat(hint): added hasNoOffset prop#10488
Merged
tlabaj merged 9 commits intopatternfly:v6from Jun 5, 2024
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-10488.surge.sh A11y report: https://patternfly-react-pr-10488-a11y.surge.sh |
tlabaj
reviewed
Jun 3, 2024
mcoker
approved these changes
Jun 3, 2024
Contributor
There was a problem hiding this comment.
LGTM! One comment would just be that where the prop goes is different between the card and hint and if it goes on the top-level component, I wonder if the prop name should reference "actions" (eg, hasNoActionsOffset).
edonehoo
suggested changes
Jun 4, 2024
Contributor
There was a problem hiding this comment.
some ideas! lmk what you think
edonehoo
reviewed
Jun 4, 2024
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
edonehoo
approved these changes
Jun 4, 2024
tlabaj
reviewed
Jun 4, 2024
| expect(asFragment()).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| test('actions are rendered', () => { |
Contributor
There was a problem hiding this comment.
maybe verify here that the no offset style is not applied. Or add a new assertion.
…ly-react into feat/10485-hint-offset
tlabaj
approved these changes
Jun 5, 2024
Contributor
|
Just needs a rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #10485
Additional issues: Follow-up to patternfly/patternfly#6708
This PR:
hasNoOffsetprop on the Hint componentactionsbehavior to only conditionally render thediv.pf-v6-c-hint__actionsif theactionsprop is passed