fix(hint): remove extra hint actions space#6708
Conversation
|
Preview: https://patternfly-pr-6708.surge.sh A11y report: https://patternfly-pr-6708-a11y.surge.sh |
There was a problem hiding this comment.
LGTM though in hint, we apply the negative margin to a plain menu toggle directly, and in the card we apply it to the actions container with a .pf-m-no-offset modifier to remove it. IMO I think consistency with the card would be better because
- allow any sort of plain thing (like a plain button) to get this styling without having to add components/variations to the selector list of what gets a negative margin
- consistency makes a more familiar API and hints seem to effectively be cards without all the bells-n-whistles
- keeps the hint styles on hint elements instead of needing to override other components. related, since this styles a menu toggle as a child of the hint actions, if there were a nested menu toggle, or a menu toggle anywhere in the actions box other than the top-level menu toggles in our examples, it would get the styling, too, which likely isn't wanted
|
@mcoker makes sense to me, thanks for the reference - pushed these updates referencing Card as the example to follow 👍 |
There was a problem hiding this comment.
LGTM, we could add an example, but that can always come later. Would that be a quick add @evwilkin? Using a primary button in place of the plain button would match the card example.
|
@mcoker thanks for the suggestion ✅ |
|
🎉 This PR is included in version 6.0.0-alpha.144 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #6116
This PR mirrors the negative margin-start on hint actions to the margin-bottom, to remove extra spacing added in the hint by the hint actions.