chore(backstop): update screenshots#7214
Merged
mcoker merged 1 commit intopatternfly:mainfrom Nov 13, 2024
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-7214.surge.sh A11y report: https://patternfly-pr-7214-a11y.surge.sh |
Member
|
There are lots of lemur messages at the end of the pdf - did they not load? |
Collaborator
|
🎉 This PR is included in version 6.1.0-prerelease.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran when reviewing #7213
isBetain the title that you can still see on org (https://www.patternfly.org/components/table/html/draggable-rows-example-isbeta/) and that was fixed yesterday (chore(table): fix draggable beta label #7200), so the backstop screenshots for that example have been saved under the filename with "isBeta" in the title up until yesterday, so this backstop run is probably comparing against a very old version of that example.__codeelement from<code>to a<div>to match react and our own documentation -<code>preserved whitespace/newlines in the example and the<div>does not.Everything else looks to be intentional example changes, new/renamed examples lacking a reference image, and random false positives.
BackstopJS Report.pdf