fix(menu toggle): correct spacing for split menu-toggle__toggle-icon that contains svg for icon#7213
Merged
mcoker merged 1 commit intopatternfly:mainfrom Nov 13, 2024
Merged
Conversation
…that contains svg for icon
Collaborator
|
Preview: https://patternfly-pr-7213.surge.sh A11y report: https://patternfly-pr-7213-a11y.surge.sh |
mcoker
approved these changes
Nov 13, 2024
Contributor
There was a problem hiding this comment.
LPTM! Also love the simplicity of this change. Sometimes these alignment issues turn into huge changesets with lots of sweeping changes. I really appreciate narrowing this down to a straight forward, easy fix 👍
Contributor
|
Also meant to mention that I ran backstop and all is good. Also made this change in the react verified it fixes the issue we raised. |
thatblindgeye
approved these changes
Nov 13, 2024
Collaborator
|
🎉 This PR is included in version 6.1.0-prerelease.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7137
The react
MenuTogglecomponent uses an<svg>for themenu toggleicon, instead of an<i>used by core.Removing
display: flexfrompf-v6-c-menu-toggle__toggle-iconbecause it causes a bug where thesvgCaretDownIconis misaligned with the text and the button height to grow taller.Before and after
https://patternfly-pr-7213.surge.sh/components/menus/menu-toggle#split-toggle