fix(label): added disabled styles#6445
Conversation
|
Preview: https://patternfly-pr-6445.surge.sh A11y report: https://patternfly-pr-6445-a11y.surge.sh |
There was a problem hiding this comment.
i think it looks good. Thanks
| {{> label | ||
| label--IsRemovable=true | ||
| label--IsDisabled=true | ||
| label-content--IsLink=true | ||
| label--id=(concat label--variants--id '-status-link-removable-disabled') | ||
| label-text--value=(concat label--variants--title ' link removable (disabled)')}} |
There was a problem hiding this comment.
I don't think we should show link labels being disabled (at least not the whole label). While you can't click the link to activate it, you can still activate/focus it via keyboard. Also not sure when it may make sense to disable an <a> element, and at that point it's not really a link but rather just text.
If this variant could be updated so that only the "remove" button is disabled, but the rest of the label has its normal styling (and the link works on mouse click) it could be worth keeping in, but otherwise probably better to just remove it.
There was a problem hiding this comment.
Great feedback! Just for reference from our convo offline, adding for now since we have this as an established (anti-?)pattern already in the library, and will investigate a better approach to this via the spike issue you created. If we can fit this change in the timeline for penta, that would be great!
|
@thatblindgeye would you mind re-reviewing when you get a chance? Added |
|
@mcoker left a comment on the other label PR, but did you mean to use aria-disabled instead to match the button as links example? |
|
🎉 This PR is included in version 6.0.0-alpha.106 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #6442