fix(label): added support for disabled labels#6424
Conversation
|
Preview: https://patternfly-pr-6424.surge.sh A11y report: https://patternfly-pr-6424-a11y.surge.sh |
|
@mcoker looks like a11y tests are failing on |
There was a problem hiding this comment.
Other than the duplicate ids, looks great! 🏷️
|
|
||
| {{> label | ||
| label--isRemovable=true | ||
| label--id=(concat label-template-variants--id '-link-removable') |
There was a problem hiding this comment.
Probably want to add -disabled to the id?
|
|
||
| {{> label | ||
| label--isRemovable=true | ||
| label--id=(concat label-template-variants--id '-clickable-removable') |
There was a problem hiding this comment.
Probably want to add -disabled to the id?
| {{> label | ||
| label--isRemovable=true | ||
| label--id=(concat label-template-variants--id '-link-disabled') | ||
| label--IsDisabled=true | ||
| label-text--value=(concat label-template-variants--title ' link removable (disabled)') | ||
| label-content--IsLink=true | ||
| label-icon--value="info-circle"}} |
There was a problem hiding this comment.
Similar to my comment in the v6 PR about disabled link labels.
| href="#" | ||
| {{#if label--IsDisabled}} | ||
| tabindex="-1" | ||
| aria-hidden="true" |
There was a problem hiding this comment.
Might be better to use aria-disabled here instead. Just thinking if it would be confusing for there to be a "close" button for something that is hidden from AT.
There was a problem hiding this comment.
🤦♂️ totally meant for that to be aria-disabled, nice catch.
|
🎉 This PR is included in version 5.3.0-prerelease.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #6055