Fix Conformance Test #363
Merged
Fix Conformance Test #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
==========================================
- Coverage 77.32% 77.25% -0.08%
==========================================
Files 89 89
Lines 2518 2519 +1
Branches 426 426
==========================================
- Hits 1947 1946 -1
- Misses 452 453 +1
- Partials 119 120 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This is the first congratulation I had that is accompanied with a Pull Request. I consider it the best kind @iamcarbon |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They certinfa url was updated. This PR updates the url and improves the error message if it goes down in the future. This PR also updates the test dependencies to their latest versions.
@abergs @aseigler Ready for review!
Also, congratulati 8000 ons on the BitWarden acquisition!