Strongly type AaGuid #362
Merged
Strongly type AaGuid #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamcarbon
commented
Jan 16, 2023
| public string CredType { get; set; } | ||
| public System.Guid Aaguid { get; set; } | ||
|
|
||
| public Guid AaGuid { get; set; } |
There was a problem hiding this comment.
Breaking change: updated casing for consistency.
|
mds3.certinfra.fidoalliance.org is currently offline -- causing the tests to fail. |
|
Agreed, I think v4 should contain the bits for passkey. |
Codecov Report
@@ Coverage Diff @@
## master #362 +/- ##
==========================================
- Coverage 77.25% 76.80% -0.45%
==========================================
Files 89 89
Lines 2519 2531 +12
Branches 426 427 +1
==========================================
- Hits 1946 1944 -2
- Misses 453 466 +13
- Partials 120 121 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aseigler
approved these changes
Jan 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates AaGuid fields from a string to a Guid. This eliminates some allocations and the need to parse the Guid later.
Making as a draft until mds3.certinfra.fidoalliance.org goes back online and tests are green.