-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
DEPR: attrs #52152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
DEPR: attrs #52152
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b338f8d
DEPR: attrs
jbrockmendel 5ee0aa3
Merge branch 'main' into depr-attrs
jbrockmendel cc562c3
ignore pickle warning
jbrockmendel 1f75880
Merge branch 'main' into depr-attrs
jbrockmendel 2a89010
Merge branch 'main' into depr-attrs
jbrockmendel 5517c7c
Merge branch 'main' into depr-attrs
jbrockmendel ed9f73c
Merge branch 'main' into depr-attrs
jbrockmendel 28e5165
catch warning in new tests
jbrockmendel 3087ced
Merge branch 'main' into depr-attrs
jbrockmendel 3fac5df
Merge branch 'main' into depr-attrs
jbrockmendel 4484b37
catch in new test
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Merge branch 'main' into depr-attrs
- Loading branch information
commit 5517c7ce40685794380e05ef9d1531d8dda09a27
There are no files selected for viewing
8000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure that creating a subclass is the advice we want to give to users to retain the behaviour (generally users should be very wary about creating a custom subclass).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems reasonable. Did you have something else in mind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I am not aware of a good alternative. But so that's the part we should discuss before deprecating it.