8000 DEPR: attrs by jbrockmendel · Pull Request #52152 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content
/ pandas Public

DEPR: attrs #52152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

DEPR: attrs #52152

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b338f8d
DEPR: attrs
jbrockmendel Mar 24, 2023
5ee0aa3
Merge branch 'main' into depr-attrs
jbrockmendel Mar 24, 2023
cc562c3
ignore pickle warning
jbrockmendel Mar 24, 2023
1f75880
Merge branch 'main' into depr-attrs
jbrockmendel Apr 6, 2023
2a89010
Merge branch 'main' into depr-attrs
jbrockmendel Apr 13, 2023
5517c7c
Merge branch 'main' into depr-attrs
jbrockmendel Apr 13, 2023
ed9f73c
Merge branch 'main' into depr-attrs
jbrockmendel Apr 21, 2023
28e5165
catch warning in new tests
jbrockmendel Apr 22, 2023
3087ced
Merge branch 'main' into depr-attrs
jbrockmendel Apr 28, 2023
3fac5df
Merge branch 'main' into depr-attrs
jbrockmendel Apr 29, 2023
4484b37
catch in new test
jbrockmendel Apr 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into depr-attrs
  • Loading branch information
@jbrockmendel
jbrockmendel committed Apr 6, 2023
commit 1f758801d6b1697982cd14d45fec78c79445d7c6
5 changes: 5 additions & 0 deletions doc/source/whatsnew/v2.1.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,12 @@ Deprecations
- Deprecated 'method', 'limit', and 'fill_axis' keywords in :meth:`DataFrame.align` and :meth:`Series.align`, explicitly call ``fillna`` on the alignment results instead (:issue:`51856`)
- Deprecated 'broadcast_axis' keyword in :meth:`Series.align` and :meth:`DataFrame.align`, upcast before calling ``align`` with ``left = DataFrame({col: left for col in right.columns}, index=right.index)`` (:issue:`51856`)
- Deprecated the 'axis' keyword in :meth:`.GroupBy.idxmax`, :meth:`.GroupBy.idxmin`, :meth:`.GroupBy.fillna`, :meth:`.GroupBy.take`, :meth:`.GroupBy.skew`, :meth:`.GroupBy.rank`, :meth:`.GroupBy.cumprod`, :meth:`.GroupBy.cumsum`, :meth:`.GroupBy.cummax`, :meth:`.GroupBy.cummin`, :meth:`.GroupBy.pct_change`, :meth:`GroupBy.diff`, :meth:`.GroupBy.shift`, and :meth:`DataFrameGroupBy.corrwith`; for ``axis=1`` operate on the underlying :class:`DataFrame` instead (:issue:`50405`, :issue:`51046`)
- Deprecated passing a dictionary to :meth:`.SeriesGroupBy.agg`; pass a list of aggregations instead (:issue:`50684`)
- Deprecated :meth:`DataFrame.attrs`, :meth:`Series.attrs`, to retain the old attribute propagation override ``__finalize__`` in a subclass (:issue:`51280`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that creating a subclass is the advice we want to give to users to retain the behaviour (generally users should be very wary about creating a custom subclass).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems reasonable. Did you have something else in mind?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you have something else in mind?

No, I am not aware of a good alternative. But so that's the part we should discuss before deprecating it.

- Deprecated logical operations (``|``, ``&``, ``^``) between pandas objects and dtype-less sequences (e.g. ``list``, ``tuple``), wrap a sequence in a :class:`Series` or numpy array before operating instead (:issue:`51521`)
- Deprecated the methods :meth:`Series.bool` and :meth:`DataFrame.bool` (:issue:`51749`)
- Deprecated :meth:`DataFrame.swapaxes` and :meth:`Series.swapaxes`, use :meth:`DataFrame.transpose` or :meth:`Series.transpose` instead (:issue:`51946`)
- Deprecated parameter ``convert_type`` in :meth:`Series.apply` (:issue:`52140`)
-


Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.
0