8000 ENH: Add ignore_index for df.drop_duplicates by charlesdong1991 · Pull Request #30405 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

ENH: Add ignore_index for df.drop_duplicates #30405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 27, 2019
Merged

ENH: Add ignore_index for df.drop_duplicates #30405

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7e461a1
remove \n from docstring
charlesdong1991 Dec 3, 2018
1314059
fix conflicts
charlesdong1991 Jan 19, 2019
8bcb313
Merge remote-tracking branch 'upstream/master'
charlesdong1991 Jul 30, 2019
3faf5cc
Merge remote-tracking branch 'upstream/master' into fix_issue_30114_d…
charlesdong1991 Dec 22, 2019
bdda8ca
Add ignore_index for drop duplicates
charlesdong1991 Dec 22, 2019
6e76e56
add forgotten test and code change based on review
charlesdong1991 Dec 22, 2019
c12beb6
code change on WA review
charlesdong1991 Dec 23, 2019
1b6dc51
keep consistency
charlesdong1991 Dec 23, 2019
17dbcb0
code change based on JR review
charlesdong1991 Dec 24, 2019
a173eea
add test
charlesdong1991 Dec 24, 2019
4a37e8f
restore wrong deleted code
charlesdong1991 Dec 24, 2019
79a49e1
remove
charlesdong1991 Dec 24, 2019
5fb6e54
Merge remote-tracking branch 'upstream/master' into fix_issue_30114_d…
charlesdong1991 Dec 26, 2019
a8552d8
code change based on JR review
charlesdong1991 Dec 26, 2019
6eaff2e
simplify code
charlesdong1991 Dec 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
remove \n from docstring
  • Loading branch information
@charlesdong1991
charlesdong1991 committed Dec 3, 2018
commit 7e461a18d9f6928132afec6f48ce968b3e989ba6
26 changes: 13 additions & 13 deletions pandas/core/arrays/datetimes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def f(self):
return result

f.__name__ = name
f.__doc__ = docstring
f.__doc__ = "\n{}\n".format(docstring)
return property(f)


Expand Down Expand Up @@ -1072,19 +1072,19 @@ def date(self):

return tslib.ints_to_pydatetime(timestamps, box="date")

year = _field_accessor('year', 'Y', "\n The year of the datetime\n")
year = _field_accessor('year', 'Y', "The year of the datetime")
month = _field_accessor('month', 'M',
"\n The month as January=1, December=12 \n")
day = _field_accessor('day', 'D', "\nThe days of the datetime\n")
hour = _field_accessor('hour', 'h', "\nThe hours of the datetime\n")
minute = _field_accessor('minute', 'm', "\nThe minutes of the datetime\n")
second = _field_accessor('second', 's', "\nThe seconds of the datetime\n")
"The month as January=1, December=12")
day = _field_accessor('day', 'D', "The days of the datetime")
hour = _field_accessor('hour', 'h', "The hours of the datetime")
minute = _field_accessor('minute', 'm', "The minutes of the datetime")
second = _field_accessor('second', 's', "The seconds of the datetime")
microsecond = _field_accessor('microsecond', 'us',
"\nThe microseconds of the datetime\n")
"The microseconds of the datetime")
nanosecond = _field_accessor('nanosecond', 'ns',
"\nThe nanoseconds of the datetime\n")
"The nanoseconds of the datetime")
weekofyear = _field_accessor('weekofyear', 'woy',
"\nThe week ordinal of the year\n")
"The week ordinal of the year")
week = weekofyear
_dayofweek_doc = """
The day of the week with Monday=0, Sunday=6.
Expand Down Expand Up @@ -1129,12 +1129,12 @@ def date(self):
"The name of day in a week (ex: Friday)\n\n.. deprecated:: 0.23.0")

dayofyear = _field_accessor('dayofyear', 'doy',
"\nThe ordinal day of the year\n")
quarter = _field_accessor('quarter', 'q', "\nThe quarter of the date\n")
"The ordinal day of the year")
quarter = _field_accessor('quarter', 'q', "The quarter of the date")
days_in_month = _field_accessor(
'days_in_month',
'dim',
"\nThe number of days in the month\n")
"The number of days in the month")
daysinmonth = days_in_month
_is_month_doc = """
Indicates whether the date is the {first_or_last} day of the month.
Expand Down
16 changes: 8 additions & 8 deletions pandas/core/arrays/timedeltas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def f(self):
return result

f.__name__ = name
f.__doc__ = docstring
f.__doc__ = "\n{}\n".format(docstring)
return property(f)


Expand Down Expand Up @@ -684,16 +684,16 @@ def to_pytimedelta(self):
return tslibs.ints_to_pytimedelta(self.asi8)

days = _field_accessor("days", "days",
"\nNumber of days for each element.\n")
"Number of days for each element.")
seconds = _field_accessor("seconds", "seconds",
"\nNumber of seconds (>= 0 and less than 1 day) "
"for each element.\n")
"Number of seconds (>= 0 and less than 1 day) "
"for each element.")
microseconds = _field_accessor("microseconds", "microseconds",
"\nNumber of microseconds (>= 0 and less "
"than 1 second) for each element.\n")
"Number of microseconds (>= 0 and less "
"than 1 second) for each element.")
nanoseconds = _field_accessor("nanoseconds", "nanoseconds",
"\nNumber of nanoseconds (>= 0 and less "
"than 1 microsecond) for each element.\n")
"Number of nanoseconds (>= 0 and less "
"than 1 microsecond) for each element.")

@property
def components(self):
Expand Down
0