8000 ENH: Add ignore_index for df.drop_duplicates by charlesdong1991 · Pull Request #30405 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

ENH: Add ignore_index for df.drop_duplicates #30405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 27, 2019
Merged

ENH: Add ignore_index for df.drop_duplicates #30405

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7e461a1
remove \n from docstring
charlesdong1991 Dec 3, 2018
1314059
fix conflicts
charlesdong1991 Jan 19, 2019
8bcb313
Merge remote-tracking branch 'upstream/master'
charlesdong1991 Jul 30, 2019
3faf5cc
Merge remote-tracking branch 'upstream/master' into fix_issue_30114_d…
charlesdong1991 Dec 22, 2019
bdda8ca
Add ignore_index for drop duplicates
charlesdong1991 Dec 22, 2019
6e76e56
add forgotten test and code change based on review
charlesdong1991 Dec 22, 2019
c12beb6
code change on WA review
charlesdong1991 Dec 23, 2019
1b6dc51
keep consistency
charlesdong1991 Dec 23, 2019
17dbcb0
code change based on JR review
charlesdong1991 Dec 24, 2019
a173eea
add test
charlesdong1991 Dec 24, 2019
4a37e8f
restore wrong deleted code
charlesdong1991 Dec 24, 2019
79a49e1
remove
charlesdong1991 Dec 24, 2019
5fb6e54
Merge remote-tracking branch 'upstream/master' into fix_issue_30114_d…
charlesdong1991 Dec 26, 2019
a8552d8
code change based on JR review
charlesdong1991 Dec 26, 2019
6eaff2e
simplify code
charlesdong1991 Dec 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
keep consistency
  • Loading branch information
@charlesdong1991
charlesdong1991 committed Dec 23, 2019
commit 1b6dc51a06102d8f88cf11fac6f0268d971556a6
2 changes: 1 addition & 1 deletion pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4626,7 +4626,7 @@ def drop_duplicates(
new_data = self._data.take(inds)

if ignore_index:
new_data.axes[1] = ibase.default_index(len(inds))
new_data = new_data.reset_index(drop=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use reset_index, simply use what you did in the other PR, default_index. .reset_index() causes another copy here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, changed!

self._update_inplace(new_data)
else:
result = self[-duplicated]
Expand Down
0