-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
CI: Linting with azure instead of travis #22854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
46620f2
dc8c528
adeb0ca
dcfb203
b765df8
3c77fc9
3d8af7d
ed1064d
8cb7b0f
dee5a08
54f9e98
20cb360
50d2757
19a213c
0cf5da9
4d10702
a356f03
50cb867
091193c
4a2ddba
e7c276a
8f73c08
87b5048
dc2e3a6
5ab03ab
ca9e12a
c591a17
c671da5
a6eed3e
3b853f9
850202d
a896532
bed55be
e555ce0
101f7f3
fce22e6
167f6dc
d44f189
906da22
9fb3999
c72c0e5
de1f52f
e4aa371
f33b6e6
63cfd5b
eb558df
371f06e
ca6e910
d262a04
fc4574c
168ec55
2f1b270
798698d
a3f601c
5ea21c6
46d281c
faf49e9
fa4f16c
c05f6b7
9162aeb
5640907
0286099
629a209
588d153
bc9c3b3
324b1e2
5bf1709
7cf2d68
2f8441e
30ba23e
85172b3
450f84a
7b4b1ea
5d69e8b
3ce1aa0
ee01df4
e353e8a
92a3921
9e34037
5a82f59
6cbb31b
2617696
75ad473
7af04e1
cc4331c
c5df401
4eac8bb
00032d1
e9ab754
e47b4e1
d0d4ae1
a225d44
d6d5c66
f7a6048
9aa18d0
283233d
991304d
Removing variable group, as variables are not in a group anymore, and…
datapythonista Nov 27, 2018
3a71185
19c396f
a69e667
59d55d8
df50c58
455e77c
7f48ac2
078a987
d7883a1
c2be491
910825a
35c7d99
d321a42
4328b04
4c57f48
497f032
c88911a
75b89eb
011950e
01942b9
0a14165
705eb9d
498cebb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
…ing better debug info on installed deps
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,7 +40,6 @@ jobs: | |
export CONDA_ENV=pandas | ||
export ENV_FILE=ci/deps/azure-checks-and-doc.yaml | ||
ci/incremental/setup_conda_environment.sh | ||
conda list -e # TODO just for debugging, remove later | ||
displayName: 'Set up environment' | ||
|
||
- script: | | ||
|
@@ -66,7 +65,6 @@ jobs: | |
|
||
- script: | | ||
export PATH=$HOME/miniconda3/bin:$PATH | ||
conda install pyqt # TODO should be in the dependencies, but not sure if it's being installed, just testing what happens | ||
ci/code_checks.sh doctests | ||
displayName: 'Running doctests' | ||
condition: true | ||
|
@@ -84,20 +82,12 @@ jobs: | |
displayName: 'Building docs' | ||
condition: true | ||
|
||
- script: | | ||
export REPO_DIR="/tmp/pandas-docs-travis" | ||
git config --global user.email "pandas-docs-bot@localhost" | ||
git config --global user.name "pandas-docs-bot" | ||
# TODO PANDAS_GH_TOKEN needs to be added as a secret variable | ||
git clone "https://${PANDAS_GH_TOKEN}@github.com/pandas-dev/pandas-docs-travis.git" $REPO_DIR | ||
git branch gh-pages --track origin/gh-pages | ||
git checkout gh-pages | ||
# TODO if this is th 8000 e build from master, and not from a PR, the build should | ||
# be in the root replacing the old build, and not in a new directory | ||
cp -r doc/build/html $REPO_DIR/$(System.PullRequest.PullRequestId) | ||
cp LICENSE $REPO_DIR/$(System.PullRequest.PullRequestId) | ||
git add --all . | ||
git commit -m "Added pandas documentation of pull request $(System.PullRequest.PullRequestId)" | ||
git push | ||
displayName: 'Uploading docs' | ||
- task: PublishBuildArtifacts@1 | ||
inputs: | ||
pathtoPublish: $(Build.SourcesDirectory)/doc/build/html | ||
artifactName: 'docs' | ||
publishLocation: 'Container' | ||
parallel: true | ||
parallelCount: 8 | ||
displayName: 'Publshing docs' | ||
condition: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why did you add running benchmarks when the original issue was just to migrate Also, as your changes did not actually modify any Python benchmark code, it was not possible to review how it would look in the Azure logs. This log here from another PR (#23752) is unfortunately impossible to read: https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=4580 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, it's somewhat debatable as to whether we even want to just run benchmarks when there's only a diff in |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm...IMO, I think running doctests should be a separate build entirely from linting. They are two semantically different things, and the separation would allow us to provide more semantically clear display names such as "Doctests" and "Linting" instead of the slightly vaguer mashup of "Checks_and_doc".
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see there was a concern about not having to use an extra build for this due to resource constraints (the conversation is a very long in this PR...)? However, I'm not sure I fully understand...
Also, based on the conversation, are the
master
docs no longer being published on https://pandas-docs.github.io/pandas-docs-travis? In which case, we need to update theGITHUB_ISSUE
template that we have here.