CI: Linting with azure instead of travis #22854
…m work
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,12 +27,8 @@ jobs: | |
| - job: 'Checks_and_doc' | ||
| pool: | ||
| vmImage: ubuntu-16.04 | ||
| timeoutInMinutes: 90 | ||
| steps: | ||
| - script: | | ||
| # XXX not sure why setting $PATH here does not work | ||
| # echo '##vso[task.setvariable variable=PATH]$HOME/miniconda3/bin:$PATH' | ||
|
|
@@ -44,7 +40,6 @@ jobs: | |
| # Do not require a conda environment | ||
| - script: | | ||
| export PATH=$HOME/miniconda3/bin:$PATH | ||
| ci/code_checks.sh patterns | ||
| displayName: 'Looking for unwanted patterns' | ||
| condition: true | ||
|
|
@@ -114,16 +109,23 @@ jobs: | |
| condition: true | ||
|
|
||
| - script: | | ||
| if [ "$(Build.SourceBranch)" == "refs/heads/master" ]; then | ||
| export NAME="master" | ||
| else | ||
| export NAME=$(System.PullRequest.PullRequestId) | ||
| fi | ||
| echo $CONNECTION_STRING | wc -c | ||
| az extension add --name storage-preview | ||
| az storage blob upload-batch --connection-string $CONNECTION_STRING \ | ||
|
There was a problem hiding this comment. A difference I see is that I'm relying on - script: |
az extension add --name storage-preview
az storage blob upload-batch -s some/path/ -d '$web'
env:
AZURE_STORAGE_CONNECTION_STRING: $(CONNECTION_STRING)But I think this may be a red herring... will reply with another comment on what I think is going on. There was a problem hiding this comment. FYI @datapythonista the correct environment variable is now called There was a problem hiding this comment. (In the process of writing out the below instructions, I just realized what's happening. Will follow up with another comment.) Since the pipeline variable now has the correct name, this should work: - script: | if [ "$(Build.SourceBranch)" == "refs/heads/master" ]; then export NAME="master" else export NAME=$(System.PullRequest.PullRequestId) fi az extension add --name storage-preview az storage blob upload-batch --source $SOURCE \ --destination '$web' --destination-path "docs/$NAME" displayName: 'Publishing docs (Azure storage)' condition: true env: AZURE_STORAGE_CONNECTION_STRING: $(AZURE_STORAGE_CONNECTION_STRING) # this should map in the secret explicitly SOURCE: $(Build.SourcesDirectory)/doc/build/html/ |
||
| --source $SOURCE \ | ||
| --destination $DESTINATION \ | ||
| --destination-path $NAME | ||
| displayName: 'Publishing docs (Azure storage)' | ||
| condition: true | ||
| env: | ||
| CONNECTION_STRING: $(AZURE_STORAGE_CONNECTION_STRING) | ||
| SOURCE: $(Build.SourcesDirectory)/doc/build/html/ | ||
| DESTINATION: 'docs' | ||
|
There was a problem hiding this comment. I realize we haven't gotten to the bottom of the secrets/connection string thing, but also, the Azure static sites feature requires that your destination container be the string |
||
|
|
||
| - script: | | ||
| if [ "$(Build.SourceBranch)" == "refs/heads/master" ]; then | ||
|
|
@@ -156,19 +158,16 @@ jobs: | |
| if git diff upstream/master --name-only | grep -q "^asv_bench/"; then | ||
| cd asv_bench | ||
| asv machine --yes | ||
| ASV_OUTPUT=$(asv dev) | ||
| if [[ $(echo $ASV_OUTPUT | grep "failure") ]]; then | ||
| echo "##vso[task.logissue type=error]Benchmarks run with errors" | ||
| echo $ASV_ERRORS | ||
| exit 1 | ||
| else | ||
| echo "Benchmarks run without errors" | ||
| fi | ||
| else | ||
| echo "Benchmarks did not run, no changes detected" | ||
| fi | ||
| displayName: 'Running benchmarks' | ||
| condition: true | ||
|
There was a problem hiding this comment. Why did you add running benchmarks when the original issue was just to migrate Also, as your changes did not actually modify any Python benchmark code, it was not possible to review how it would look in the Azure logs. This log here from another PR (#23752) is unfortunately impossible to read: https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=4580 There was a problem hiding this comment. Also, it's somewhat debatable as to whether we even want to just run benchmarks when there's only a diff in |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, you can
echo "##vso[task.prependpath]$HOME/miniconda3/bin"here to make the path change durable for the job.