8000 ENH: Allow rename_axis to specify index and columns arguments by Dr-Irv · Pull Request #20046 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

ENH: Allow rename_axis to specify index and columns arguments #20046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Oct 29, 2018
Merged

ENH: Allow rename_axis to specify index and columns arguments #20046

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
bb12644
First version
Dr-Irv Mar 7, 2018
99011df
some doc changes
Dr-Irv Mar 7, 2018
4b45493
full implementation
Dr-Irv Mar 7, 2018
5ff65a6
First test of new rename_axis
Dr-Irv Mar 7, 2018
36e5412
Merge remote-tracking branch 'upstream/master' into issue19978
Dr-Irv Mar 8, 2018
a14e6a1
Doc changes and resolve conflicts with master
Dr-Irv Mar 8, 2018
c8d6604
Merge in latest master
Dr-Irv Jul 9, 2018
5806d9a
Fix doc merge
Dr-Irv Jul 9, 2018
f28246f
Merge to latest master
Dr-Irv Sep 25, 2018
2f53685
fix flake8 issue
Dr-Irv Sep 25, 2018
5fd1ddf
Make whatsnew show example
Dr-Irv Sep 26, 2018
3e8aaf3
fix docstring
Dr-Irv Sep 26, 2018
5ec7748
Merge with master
Dr-Irv Oct 19, 2018
5c9c3ce
Merge remote-tracking branch 'upstream/master' into issue19978
Dr-Irv Oct 24, 2018
0542cf0
doc fix. Move get_rename_function to common
Dr-Irv Oct 24, 2018
39938a1
Fix signature of rename_axis, add docs
Dr-Irv Oct 25, 2018
65e3733
Doc fixes, make get_rename_function private
Dr-Irv Oct 26, 2018
e965c5b
stacklevel for warnings
Dr-Irv Oct 26, 2018
1263a47
merge to handle isort
Dr-Irv Oct 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
stacklevel for warnings
  • Loading branch information
@Dr-Irv
Dr-Irv committed Oct 26, 2018
commit e965c5b603595a8454933e479e7ce74445b2c6e2
2 changes: 1 addition & 1 deletion pandas/core/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1255,7 +1255,7 @@ def 8000 rename_axis(self, mapper=None, **kwargs):
# and not a list or scalar, then call rename
msg = ("Using 'rename_axis' to alter labels is deprecated. "
"Use '.rename' instead")
warnings.warn(msg, FutureWarning, stacklevel=2)
warnings.warn(msg, FutureWarning, stacklevel=3)
axis = self._get_axis_name(axis)
d = {'copy': copy, 'inplace': inplace}
d[axis] = mapper
Expand Down
12 changes: 4 additions & 8 deletions pandas/tests/frame/test_alter_axes.py
View file
Open in desktop
5C97
Original file line number Diff line number Diff line change
Expand Up @@ -522,23 +522,19 @@ def test_rename_axis_inplace(self, float_frame):
def test_rename_axis_warns(self):
# https://github.com/pandas-dev/pandas/issues/17833
df = DataFrame({"A": [1, 2], "B": [1, 2]})
with tm.assert_produces_warning(FutureWarning,
check_stacklevel=False) as w:
with tm.assert_produces_warning(FutureWarning) as w:
df.rename_axis(id, axis=0)
assert 'rename' in str(w[0].message)

with tm.assert_produces_warning(FutureWarning,
check_stacklevel=False) as w:
with tm.assert_produces_warning(FutureWarning) as w:
df.rename_axis({0: 10, 1: 20}, axis=0)
assert 'rename' in str(w[0].message)

with tm.assert_produces_warning(FutureWarning,
check_stacklevel=False) as w:
with tm.assert_produces_warning(FutureWarning) as w:
df.rename_axis(id, axis=1)
assert 'rename' in str(w[0].message)

with tm.assert_produces_warning(FutureWarning,
check_stacklevel=False) as w:
with tm.assert_produces_warning(FutureWarning) as w:
df['A'].rename_axis(id)
assert 'rename' in str(w[0].message)

Expand Down
0