8000 ENH: Allow rename_axis to specify index and columns arguments by Dr-Irv · Pull Request #20046 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

ENH: Allow rename_axis to specify index and columns arguments #20046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Oct 29, 2018
Merged

ENH: Allow rename_axis to specify index and columns arguments #20046

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
bb12644
First version
Dr-Irv Mar 7, 2018
99011df
some doc changes
Dr-Irv Mar 7, 2018
4b45493
full implementation
Dr-Irv Mar 7, 2018
5ff65a6
First test of new rename_axis
Dr-Irv Mar 7, 2018
36e5412
Merge remote-tracking branch 'upstream/master' into issue19978
Dr-Irv Mar 8, 2018
a14e6a1
Doc changes and resolve conflicts with master
Dr-Irv Mar 8, 2018
c8d6604
Merge in latest master
Dr-Irv Jul 9, 2018
5806d9a
Fix doc merge
Dr-Irv Jul 9, 2018
f28246f
Merge to latest master
Dr-Irv Sep 25, 2018
2f53685
fix flake8 issue
Dr-Irv Sep 25, 2018
5fd1ddf
Make whatsnew show example
Dr-Irv Sep 26, 2018
3e8aaf3
fix docstring
Dr-Irv Sep 26, 2018
5ec7748
Merge with master
Dr-Irv Oct 19, 2018
5c9c3ce
Merge remote-tracking branch 'upstream/master' into issue19978
Dr-Irv Oct 24, 2018
0542cf0
doc fix. Move get_rename_function to common
Dr-Irv Oct 24, 2018
39938a1
Fix signature of rename_axis, add docs
Dr-Irv Oct 25, 2018
65e3733
Doc fixes, make get_rename_function private
Dr-Irv Oct 26, 2018
e965c5b
stacklevel for warnings
Dr-Irv Oct 26, 2018
1263a47
merge to handle isort
Dr-Irv Oct 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Doc changes and resolve conflicts with master
  • Loading branch information
@Dr-Irv
Dr-Irv committed Mar 8, 2018
commit a14e6a1e66a3bc74aad7f9654ec51e4508eb0fed
10000
7 changes: 5 additions & 2 deletions pandas/core/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,6 +751,10 @@ def swaplevel(self, i=-2, j=-1, axis=0):

# renamer function if passed a dict
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you just moved the function, but let's take this opportunity to write a brief docstring.

def _get_rename_function(self, mapper):
"""
Returns a function that will map names/labels, dependent if mapper
is a dict, Series or just a function.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't need to be here (in the class). is it used in more than 1 place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is used in both rename() and rename_axis()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, but it doesn't need self right? can you move to pandas/core/common.py i think is ok for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have moved it and removed leading underscore

"""
if isinstance(mapper, (dict, ABCSeries)):

def f(x):
Expand Down Expand Up @@ -913,8 +917,7 @@ def rename(self, *args, **kwargs):
rename.__doc__ = _shared_docs['rename']

def rename_axis(self, mapper=None, **kwargs):
"""Alter the name of the index or name of index backing the
columns.
"""Alter the name of the index or name of index backing the columns.

Parameters
----------
Expand Down
0