8000 API: Restore implicit converter registration by TomAugspurger · Pull Request #18307 · pandas-dev/pandas · GitHub
[go: up one dir, main page]

Skip to content

API: Restore implicit converter registration #18307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Dec 7, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added deprecation
  • Loading branch information
TomAugspurger committed Nov 18, 2017
commit 5ee385e9af84bb75ecd1de3e03759db7a1ddb323
8 changes: 8 additions & 0 deletions pandas/tests/plotting/test_converter.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,14 @@ def test_registry_resets(self):
for k, v in original.items():
units.registry[k] = v

def test_old_import_warns(self):
with tm.assert_produces_warning(FutureWarning) as w:
from pandas.tseries import converter
converter.register()

assert len(w)
assert 'pandas.plotting.register_converters' in str(w[0].message)


class TestDateTimeConverter(object):

Expand Down
12 changes: 11 additions & 1 deletion pandas/tseries/converter.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# flake8: noqa
import warnings

from pandas.plotting._converter import (register, time2num,
from pandas.plotting._converter import (time2num,
TimeConverter, TimeFormatter,
PeriodConverter, get_datevalue,
DatetimeConverter,
Expand All @@ -9,3 +10,12 @@
MilliSecondLocator, get_finder,
TimeSeries_DateLocator,
TimeSeries_DateFormatter)


def register():
from pandas.plotting._converter import register as register_
msg = ("'pandas.tseries.converter.register' has been moved and renamed to "
"'pandas.plotting.register_converters'. ")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

register_converters -> register_matplotlib_converters()

warnings.warn(msg, FutureWarning, stacklevel=2)
register_()

0