8000 API: Restore implicit converter registration by TomAugspurger · Pull Request #18307 · pandas-dev/pandas · GitHub
[go: up one dir, main page]

Skip to content

API: Restore implicit converter registration #18307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Dec 7, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test fixup
- actually switch the default to not warn
- We do overwrite matplotlib's formatters
  • Loading branch information
TomAugspurger committed Dec 1, 2017
commit 1112b28fb35c0613df9ebf741521abc41620593f
2 changes: 1 addition & 1 deletion pandas/plotting/_converter.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def get_pairs():
return pairs


def register(explicit=False):
def register(explicit=True):
"""Register Pandas Formatters and Converters with matplotlib

This function modifies the global ``matplotlib.units.registry``
Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/plotting/test_converter.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def test_registry_resets(self):
units.registry[date] = date_converter

register_matplotlib_converters()
assert units.registry[date] is date_converter
assert units.registry[date] is not date_converter
deregister_matplotlib_converters()
assert units.registry[date] is date_converter

Expand Down
0