unit test added for no active experiment in create impression event

optimizely · msohailhussain · Dec 22, 2021 · Dec 13, 2021 · Dec 13, 2021 · Dec 14, 2021
commit e480d8d5a37f3a707041ff2975cc8b4a3dab634d
diff --git a/optimizely/event/user_event_factory.py b/optimizely/event/user_event_factory.py
@@ -54,7 +54,7 @@ def create_impression_event(
         if not variation and variation_id and experiment_id:
             # need this condition when we send events involving forced decisions
             variation = project_config.get_variation_from_id_by_experiment_id(experiment_id, variation_id)
-        
+
         event_context = user_event.EventContext(
             project_config.account_id, project_config.project_id, project_config.revision, project_config.anonymize_ip,
         )

diff --git a/tests/test_user_event_factory.py b/tests/test_user_event_factory.py
@@ -70,6 +70,17 @@ def test_impression_event__with_attributes(self):
             [x.__dict__ for x in expected_attrs], [x.__dict__ for x in impression_event.visitor_attributes],
         )
 
+    def test_impression_event__no_active_experiment(self):
+        project_config = self.project_config
+        user_id = 'test_user'
+
+        user_attributes = {'test_attribute': 'test_value', 'boolean_key': True}
+
+        impression_event = UserEventFactory.create_impression_event(
+            project_config, None, '111128', 'flag_key', 'rule_key', 'rule_type', True, user_id, user_attributes
+        )
+        self.assertIsNone(impression_event)
+
     def test_conversion_event(self):
         project_config = self.project_config
         user_id = 'test_user'